The Twenty Nineteen version shipped with WordPress 5.0 is not in sync with Github version

[ismail.elkorchi]

Many changes are missing from the Twenty Nineteen version shipped with WordPress 5.0. For exemple, this PR ​https://github.com/WordPress/twentynineteen/pull/47 was merged in november 30, and the changes made in it are asbent here : https://core.trac.wordpress.org/browser/tags/5.0/src/wp-content/themes/twentynineteen/functions.php#L224.

[swissspidy]

Seems like that was missed in #45424.

Can you perhaps confirm that @allancole?

[allancole]

Yes, unfortunately this is correct, @swissspidy. The remaining patches on #45424 we’re meant to keep the two repos in sync, but they were submitted too late to test properly and were not included in the 5.0 release.

We’re aiming to get the more critical patches into 5.0.1, but non-critical fixes and general improvements will likely appear in an 1.0.1 update to the theme itself on the wporg themes repo.

We’re going to cover this in more detail in the #core-themes meeting tomorrow (12/11).

[laurelfulford]

Thanks fore reporting this, @ismail.elkorchi!

In the past week weeks, Twenty Nineteen has fully been moved to Trac/SVN, and the GitHub repo retired; as part of that the different repos have been synced up.

I've double-checked, and the example above (the skip link JavaScript being moved inline) was included in 5.0.3, or Twenty Nineteen 1.2: https://core.trac.wordpress.org/browser/tags/5.0.3/src/wp-content/themes/twentynineteen/functions.php#L245

I'm going to close this issue since it appears to be fixed now, but just let me know if you have any questions about this at all!

[desrosj]

Removing Awaiting Review milestone from closed tickets.