WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

#45788 closed defect (bug) (fixed)

Not translated: "add media" in block classic in WP 5.0.2

Reported by: La Geek Owned by: desrosj
Milestone: 5.0.3 Priority: normal
Severity: normal Version: 5.0.2
Component: Editor Keywords: has-patch
Focuses: Cc:

Description

Although the translation is on 100% the icon "add media" is not translated. Seen in Block Classic.

Attachments (1)

45788.diff (922 bytes) - added by afercia 3 months ago.

Download all attachments as: .zip

Change History (10)

#1 @swissspidy
3 months ago

  • Component changed from I18N to Editor
  • Keywords needs-patch added

@afercia
3 months ago

#2 @afercia
3 months ago

  • Keywords needs-patch removed
  • Milestone changed from Awaiting Review to 5.0.3

45788.diff makes the tooltip string translatable.
Also, adds the keyboard shortcut to be displayed in the tooltip once https://github.com/WordPress/gutenberg/issues/6195 will be addressed.

#3 @afercia
3 months ago

  • Keywords has-patch added

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


3 months ago

#5 @audrasjb
3 months ago

  • Keywords commit added

Hi @afercia the patch works well on my side. Adding commit keyword for 5.0.3.

#6 @desrosj
3 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 44398:

Editor: Allow the “Add Media” button tooltip to be translated in the Classic block.

In the Classic Editor, the “Add Media” button was outside of the TinyMCE editor. In the Block Editor, the “Add Media” button was moved into the TinyMCE toolbar in the Classic block, but the tooltip was not added to the list of translatable strings. This adds “Add Media” to that list.

The corresponding keyboard shortcut is also specified for the “Add Media” button.

Props afercia.

Fixes #45788.

#7 @desrosj
3 months ago

  • Keywords commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport.

#8 @desrosj
3 months ago

In 44399:

Editor: Fix name of the new editor for inline comment.

In [44398], an inline comment was introduced that did not refer to the new editor as the Block Editor. This corrects that comment.

See #45788.

#9 @desrosj
3 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44400:

Editor: Allow the “Add Media” button tooltip to be translated in the Classic block.

In the Classic Editor, the “Add Media” button was outside of the TinyMCE editor. In the Block Editor, the “Add Media” button was moved into the TinyMCE toolbar in the Classic block, but the tooltip was not added to the list of translatable strings. This adds “Add Media” to that list.

The corresponding keyboard shortcut is also specified for the “Add Media” button.

Props afercia.

Merges [44398-44399] to the 5.0 branch.
Fixes #45788.

Note: See TracTickets for help on using tickets.