WordPress.org

Make WordPress Core

Opened 10 months ago

Closed 3 months ago

#45821 closed defect (bug) (fixed)

Date Related Travis Failures

Reported by: desrosj Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: minor Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:
PR Number:

Description

On occasion, a Travis build will fail when date related PHPUnit tests do not pass. It happens seemingly at random with a random PHP version.

It appears to be an issue the job in Travis not having the expected timezone.

Attachments (1)

log.txt (140.4 KB) - added by desrosj 10 months ago.
Latest failure log on PHP 7.3

Download all attachments as: .zip

Change History (8)

@desrosj
10 months ago

Latest failure log on PHP 7.3

This ticket was mentioned in Slack in #core by desrosj. View the logs.


10 months ago

This ticket was mentioned in Slack in #core by desrosj. View the logs.


8 months ago

This ticket was mentioned in Slack in #core by jeremyfelt. View the logs.


6 months ago

This ticket was mentioned in Slack in #core by sergey. View the logs.


6 months ago

#6 @SergeyBiryukov
3 months ago

  • Milestone changed from Awaiting Review to 5.3

#7 @SergeyBiryukov
3 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45857:

Date/Time: Fix race conditions in current_time() tests.

  • Restore default timezone before performing assertions to avoid affecting other tests in case of failure.
  • Use delta comparison for timestamps to avoid race conditions.

Props SergeyBiryukov, desrosj.
Fixes #45821.

Note: See TracTickets for help on using tickets.