WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#45821 closed defect (bug) (fixed)

Date Related Travis Failures

Reported by: desrosj's profile desrosj Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: minor Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:

Description

On occasion, a Travis build will fail when date related PHPUnit tests do not pass. It happens seemingly at random with a random PHP version.

It appears to be an issue the job in Travis not having the expected timezone.

Attachments (1)

log.txt​ (140.4 KB) - added by desrosj 6 years ago.
Latest failure log on PHP 7.3

Download all attachments as: .zip

Change History (12)

@desrosj
6 years ago

Latest failure log on PHP 7.3

This ticket was mentioned in ​Slack in #core by desrosj. ​View the logs.
6 years ago

This ticket was mentioned in ​Slack in #core by desrosj. ​View the logs.
6 years ago

This ticket was mentioned in ​Slack in #core by jeremyfelt. ​View the logs.
6 years ago

This ticket was mentioned in ​Slack in #core by sergey. ​View the logs.
6 years ago

#6 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 5.3

#7 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45857:

Date/Time: Fix race conditions in current_time() tests.

  • Restore default timezone before performing assertions to avoid affecting other tests in case of failure.
  • Use delta comparison for timestamps to avoid race conditions.

Props SergeyBiryukov, desrosj.
Fixes #45821.

This ticket was mentioned in ​Slack in #core-datetime by sergey. ​View the logs.
5 years ago

This ticket was mentioned in ​Slack in #core by sergey. ​View the logs.
3 years ago

#10 @SergeyBiryukov
3 years ago

In 52586:

Date/Time: Fix race conditions in current_time() tests.

  • Restore default timezone before performing assertions to avoid affecting other tests in case of failure.
  • Use delta comparison for timestamps to avoid race conditions.

Props SergeyBiryukov, desrosj.
Merges [45857] to the 5.2 branch.
Fixes #45821.

#11 @SergeyBiryukov
3 years ago

In 52587:

Date/Time: Fix race conditions in current_time() tests.

  • Restore default timezone before performing assertions to avoid affecting other tests in case of failure.
  • Use delta comparison for timestamps to avoid race conditions.

Props SergeyBiryukov, desrosj.
Merges [45857] to the 5.1 branch.
Fixes #45821.

Note: See TracTickets for help on using tickets.