WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#45865 closed enhancement (fixed)

Twenty Nineteen: Consider decreasing the font size for widget titles

Reported by: kjellr's profile kjellr Owned by: ianbelanger's profile ianbelanger
Milestone: 5.4.2 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: has-patch commit early fixed-major
Focuses: css Cc:

Description

As per discussion in the Twenty Nineteen GitHub...

​https://github.com/WordPress/twentynineteen/issues/658

... we should consider decreasing the font size for widget titles. The current font size is the same size as post titles, which seems odd hierarchically.

Before:
https://cldup.com/G0B-GOk4I5-1200x1200.png

After:
https://cldup.com/G3HS80WOwW-2000x2000.png

---
This PR was ported over from the Twenty Nineteen GitHub here:
​https://github.com/WordPress/twentynineteen/pull/671

Attachments (2)

45865.patch​ (1.4 KB) - added by kjellr 5 years ago.
45865.2.patch​ (1.4 KB) - added by mukesh27 5 years ago.
Updated patch.

Download all attachments as: .zip

Change History (14)

@kjellr
5 years ago

This ticket was mentioned in ​Slack in #core-themes by anevins. ​View the logs.
5 years ago

@mukesh27
5 years ago

Updated patch.

#2 @mukesh27
5 years ago

@kjellr updated patch and remove h2 from style-rtl.css

#3 @kjellr
5 years ago

Thanks for catching that, @mukesh27!

#4 @ianbelanger
4 years ago

  • Focuses css added
  • Milestone changed from Awaiting Review to 5.4
  • Owner set to ianbelanger
  • Priority changed from lowest to normal
  • Status changed from new to reviewing
  • Version changed from 5.0.2 to 5.0

Reviewing for commit.

#5 @ianbelanger
4 years ago

  • Keywords commit early added
  • Milestone changed from 5.4 to 5.5
  • Status changed from reviewing to accepted

Patch still applies cleanly and the fix looks good. Marking commit and early and putting in the 5.5 milestone so we can get this enhancement in soon after 5.4 is released.

This ticket was mentioned in ​Slack in #core by david.baumwald. ​View the logs.
4 years ago

#7 @davidbaumwald
4 years ago

@ianbelanger Is this still on your list to include early in the 5.5 cycle? Is there anything anyone can assist with to move this forward?

#8 @ianbelanger
4 years ago

Yes it is @davidbaumwald, I'll get it committed this week.

#9 @ianbelanger
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 47586:

Bundled Themes: Twenty Nineteen decrease the font size for widget titles.

Update styles to decrease the font size for widget titles.

Props kjellr, mukesh27.
Fixes #45865.

#10 @ianbelanger
4 years ago

  • Keywords fixed-major added
  • Milestone changed from 5.5 to 5.4.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport.

#11 @ianbelanger
4 years ago

  • Milestone changed from 5.4.1 to 5.4.2

#12 @whyisjake
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 47831:

Bundled Themes: Twenty Nineteen decrease the font size for widget titles.
Update styles to decrease the font size for widget titles.

This commit brings the changes from [47586] to the 5.4 branch.

Props kjellr, mukesh27.
Fixes #45865.

Note: See TracTickets for help on using tickets.