Context Navigation

← Previous Ticket
Next Ticket →

#46071 closed defect (bug) (fixed)

TinyMCE Classic Block: fix "Advanced Link" modal

Reported by:	azaozz	Owned by:	azaozz
Priority:	normal	Milestone:	5.1
Component:	TinyMCE	Version:	5.0
Severity:	normal	Keywords:	has-patch commit
Cc:		Focuses:

Description (last modified by azaozz)

The "Advanced Link" modal doesn't work reliably in the Classic Block instance. Sometimes it doesn't insert a link, sometimes it inserts it at the beginning of the text instead of the cursor position.

This was reported for Gutenberg some time ago. See https://github.com/WordPress/gutenberg/issues/7932 and the 6-7 issues closed as duplicates. Opening this ticket here as it is an issue with one of our old custom TinyMCE plugins.

Attachments (1)

46071.diff (5.2 KB ) - added by azaozz 7 years ago.

Download all attachments as: .zip

Change History (9)

@azaozz
7 years ago

Attachment 46071.diff added

#1 @azaozz
7 years ago

There are few reasons for these bugs. Most importantly the editor instance is inline and some "utility" functions work a bit differently.

In 46071.diff:

Refresh the wpLink modal and wplink editor plugin a bit.
Always select the (newly inserted or existing) link node after the modal has been opened. Passing it from the editor plugin breaks as the editor content is reloaded on editor.blur(), and opening the modal and clicking in it triggers that.
Remove outdated editor.focus() on opening the modal (was bad for accessibility).

Tested in Firefox, Chrome and Edge on Win10.