WordPress.org

Make WordPress Core

Opened 20 months ago

Last modified 2 months ago

#46110 assigned defect (bug)

IE11: JS "Syntax error" related to wp-polyfill-formdata

Reported by: afercia Owned by: atimmer
Milestone: 5.6 Priority: normal
Severity: normal Version: 5.0
Component: Build/Test Tools Keywords: has-screenshots has-patch
Focuses: javascript Cc:

Description

In Internet Explorer 11, there's a JavaScript "Syntax error" related to wp-polyfill-formdata. The error happens in various pages, e.g. in edit.php and post.php.

http://cldup.com/-UPS1EV0FC.png

IE11 doesn't support "arrow functions" and other ES6 features in that file. Asked for feedback on Slack #core-editor and it was pointed out that seems core is using the wrong file from the package.

Wrong version used in core:

https://github.com/WordPress/wordpress-develop/blob/e01f30a/tools/webpack/packages.js#L104

Correct version used in the Gutenberg plugin:

https://github.com/WordPress/gutenberg/blob/2d7035b/lib/client-assets.php#L619

Introduced in [43719] /Cc @omarreiss @atimmer

Attachments (1)

46110.diff (606 bytes) - added by mariyan96 11 months ago.

Download all attachments as: .zip

Change History (21)

#1 @ocean90
20 months ago

  • Component changed from General to Build/Test Tools
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.1.1

The file is only loaded if SCRIPT_DEBUG is set.

We could ask the author to include a formdata.js in a /dist directory. They are using the Closure Compiler so the WHITESPACE_ONLY option would fit for this.

#2 @atimmer
20 months ago

I've asked the author of the library to include a non-minified build file: https://github.com/jimmywarting/FormData/issues/69.

I see two possible workarounds:

  • Build the file ourselves in the webpack configuration.
  • Ship the minified file as the non-minified file.

The second one is easier to implement, the first one is better.

#3 @netweb
19 months ago

  • Owner set to atimmer
  • Status changed from new to assigned

This ticket was mentioned in Slack in #core by lukecarbis. View the logs.


19 months ago

#5 @lukecarbis
19 months ago

  • Milestone changed from 5.1.1 to 5.2

#6 @jorbin
18 months ago

  • Milestone changed from 5.2 to 5.3

Bumping due to lack of activity upstream.

#7 @afercia
16 months ago

Noting the upstream issue on GitHub has been automatically closed by the "stale bot" because of lack of activity and seems the project maintainers aren't inclined to ship a non-minified version.

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


12 months ago

#9 @netweb
12 months ago

  • Milestone changed from 5.3 to 5.4

Due to lack of updates, punting this to 5.4 to clear the way for 5.3

@mariyan96
11 months ago

#10 @mariyan96
11 months ago

  • Keywords has-patch added; needs-patch removed

Hey guys,

We were on WordPress Contributors Day (Sofia, Bulgaria) and this is my first ticket.

The changes consist of loading the minified assets which are going through Grunt. This should solve a lot of other compatibility issues as well. Attaching 46110.diff​ file with my changes.

#11 @aduth
8 months ago

Noting that the patch provided for #49423 may incidentally resolve this.

This ticket was mentioned in Slack in #core by mike. View the logs.


7 months ago

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


7 months ago

#14 @aduth
7 months ago

46110.diff may work, but only because it bypasses SCRIPT_DEBUG to force the minified script of all vendor scripts to always be loaded. While this resolves the issue of this ticket, in doing so it breaks expectations that SCRIPT_DEBUG load unminified files.

Related: https://wordpress.org/support/article/debugging-in-wordpress/#script_debug

#15 @jorgefilipecosta
7 months ago

  • Milestone changed from 5.4 to 5.5

This ticket was mentioned in Slack in #core-editor by aduth. View the logs.


6 months ago

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


3 months ago

#18 @davidbaumwald
2 months ago

@jorgefilipecosta, @aduth Is this still on your list to handle in 5.5

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


2 months ago

#20 @SergeyBiryukov
2 months ago

  • Milestone changed from 5.5 to 5.6

Per comment:14, it looks like there's still no consensus on the correct approach.

Since it was noted that #49423 might fix this, and it's already moved to 5.6, moving this ticket too along with it.

Last edited 2 months ago by SergeyBiryukov (previous) (diff)
Note: See TracTickets for help on using tickets.