#46269 closed defect (bug) (fixed)
Update `wp_update_php_annotation()` and `wp_get_update_php_annotation()` for parameters
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 5.2 | Priority: | normal |
| Severity: | normal | Version: | 5.1 |
| Component: | Site Health | Keywords: | servehappy has-patch |
| Focuses: | Cc: |
Description
Update the instances of wp_update_php_annotation() and wp_get_update_php_annotation() with the appropriate passed parameters.
In some instances it will be no parameters and in other instances it will be, wp_update_php_annotation( '<br><span class="description">', '</span>' ) and wp_get_update_php_annotation( '<br><span class="description">', '</span>' )
Part 2 for #46044
Attachments (4)
Change History (17)
This ticket was mentioned in Slack in #core-php by spacedmonkey. View the logs.
7 years ago
This ticket was mentioned in Slack in #core-php by afragen. View the logs.
7 years ago
#6
@
7 years ago
- Keywords dev-feedback needs-testing removed
- Milestone 5.2 deleted
- Resolution set to duplicate
- Status changed from new to closed
Let's close this out. The changes being proposed in 46269.diff have not been committed yet and are adjustments to the code in #44350 and #43987. Let's make these adjustments there before committing instead of patching this after the fact.
#9
@
7 years ago
- Keywords needs-refresh added
The <span> tag in the More Details area is causing a weird line-height and different padding at the bottom. That one can be changed to use the default <p class="description"> without causing any markup issues.
For the plugin cards, let's add another <br /> to provide a bit of spacing.
#10
@
7 years ago
- Version 5.1 deleted
Last patch update provides a better solution that a double <br><br>. All @desrosj's idea. 👏🏻
#11
@
7 years ago
- Keywords needs-refresh removed
- Milestone set to 5.2
- Version set to 5.1
The text color assigned to p.descriptions does not meet the minimum contrast required for accessibility standards. Removing that gets rid of the italics, but ensures proper contrast.
So here's my issue for #46269. It really relies on 43987, 44350, 46044, and 46275 to be committed to reliably write the patch.
If those patches are in place there are 2 locations where I need to pass parameters to as follows
wp_update_php_annotation( '<br><span class="description">', '</span>' )I'll try to write the patch on a _patched_ core but it's less than ideal.Those locations seem to be
wp-admin/includes/update.php:468andwp-admin/update-core.php:307I can have the patch in place within 12 hours, give or take of those other commits. or I can try to write a patch that may not cleanly apply.