WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#46517 closed defect (bug) (fixed)

CSS line-height values should be unitless - revisions.css

Reported by: ianbelanger's profile ianbelanger Owned by: ianbelanger's profile ianbelanger
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch needs-testing good-first-bug
Focuses: ui, administration, coding-standards Cc:

Description

As outlined in #44643, CSS line-height values should be unitless unless necessary to be defined as a specific pixel value. It was suggested that we break up 44643 by stylesheet in order to better track them.

This ticket covers wp-admin/css/revisions.css

Note: The patch was tested only on a Windows machine in Chrome, Firefox, IE11 and Edge. As per https://core.trac.wordpress.org/ticket/44643#comment:23 it should probably be tested on other OS's and supported browsers.

Attachments (2)

46517.diff​ (518 bytes) - added by ianbelanger 6 years ago.
46517.1.diff​ (544 bytes) - added by ianbelanger 5 years ago.
Updates patch with more precise line-height calculations

Download all attachments as: .zip

Change History (5)

@ianbelanger
6 years ago

#1 @ianbelanger
6 years ago

  • Component changed from General to Editor
  • Milestone changed from Awaiting Review to Future Release

@ianbelanger
5 years ago

Updates patch with more precise line-height calculations

#2 @ianbelanger
5 years ago

  • Milestone changed from Future Release to 5.3

#3 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45468:

CSS Coding Standards: Use unitless values for line-height in wp-admin/css/revisions.css.

Props ianbelanger, pbiron, afercia.
Fixes #46517. See #44643.

Note: See TracTickets for help on using tickets.