Opened 4 years ago
Closed 4 years ago
#46941 closed defect (bug) (fixed)
Need to add 5px space in selected admin widget items
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Widgets | Keywords: | has-screenshots has-patch |
Focuses: | ui, administration | Cc: |
Description
On mobile view display widget item very close to each other need to add some space between two widget item.
Attachments (8)
Change History (23)
#2
@
4 years ago
- Keywords has-patch has-screenshots added
Need to remove margin from class div.widget
in 480px media query.
#3
@
4 years ago
- Keywords needs-design-feedback added
- Summary changed from Need to add 5px space in selected admin widge items to Need to add 5px space in selected admin widget items
#5
@
4 years ago
- Keywords needs-refresh added; needs-design-feedback removed
See also #42001.
Some widgets have an "extra wide" interface which is discussed in #42001. For now, the left and right margins shouldn't be changed.
However, the top and bottom margin shouldn't be reset to 0
. It's not about design, it's a functional thing: when dragging a widget, the other widgets "jump" because the dashed "placeholder" has some margin:
This "jump" should be avoided. @mukesh27 approach looks good but instead of removing the margin property entirely I'd suggest to keep margin-left
and margin-right
to auto !important
.
#7
@
4 years ago
- Keywords commit added
- Version changed from 3.8.1 to trunk
Good work @mukesh27 the updated patch works very good!
#8
@
4 years ago
- Milestone changed from Awaiting Review to 5.3
- Version trunk deleted
Removing the trunk
version, as this doesn't seem to be a regression in 5.2.
#9
@
4 years ago
- Keywords commit removed
- Owner set to audrasjb
- Status changed from assigned to reviewing
Removing commit
keyword as this patch still needs some review. Putting this one on my list :-)
#10
@
4 years ago
I refreshed the patch with a full margin declaration and a 5px margin bottom (see screenshot below).
#11
@
4 years ago
- Status changed from reviewing to accepted
@afercia the last patch fix the margin gap (see animated screenshot below).
I also removed the !important declaration since it works well without using it.
#12
@
4 years ago
I'd tend to think the margin shouldn't be reduced from the original 10 pixels to 5 pixels. Especially on small screens, having more margin helps touch interaction to better target the right widget.
Looking a bit better into this, the breaking change comes from [41602] / #41614. At that time, the !important
made the declaration conflict with the desired styling within the Customizer. Instead of adding CSS to fix this, seems to me it's better to remove the declaration. The necessary margin is already inherited from the desktop view styles.
Some quick testing of 46941.3.diff would be nice :) Please also check the widgets panel in the Customizer.
#13
@
4 years ago
Alright @afercia , I tested 46941.3.diff (see animated screenshot above) and it's even better 👍
#14
@
4 years ago
@afercia 46941.3.diff patch works fine for me also.
Widget mobiel view