Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 7 years ago

Closed 7 years ago

#47040 closed defect (bug) (duplicate)

i18n: Avoid using HTML tags in translation strings in theme install

Reported by:	ramiy	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:
Component:	Themes	Version:
Severity:	normal	Keywords:	has-screenshots has-patch
Cc:		Focuses:	administration

Description

See the attached patch.

Attachments (2)

47040.png (18.8 KB ) - added by ramiy 7 years ago.
47040.patch (1.5 KB ) - added by ramiy 7 years ago.

Download all attachments as: .zip

Change History (10)

@ramiy
7 years ago

Attachment 47040.png added

@ramiy
7 years ago

Attachment 47040.patch added

#1 follow-up: ↓ 5 @ramiy
7 years ago

Keywords has-screenshots has-patch added

In this case one string has screen reader text but the other one don't.

I did two things:

I moved the screen reader text HTML tags outside of the string.
I added a screen reader text string to the second file to match the user experience.
I added a target="_blank" to the other file.

#2 follow-up: ↓ 3 @Presskopp
7 years ago

What about adding rel="noopener noreferrer" here?

#3 in reply to: ↑ 2 @ramiy
7 years ago

Replying to Presskopp:

What about adding rel="noopener noreferrer" here?

see #37941

@Presskopp This is i18n ticket, let's leave the rel="noopener noreferrer" to a separate ticket.

#4 @SergeyBiryukov
7 years ago

Milestone Awaiting Review → 5.3

#5 in reply to: ↑ 1 @SergeyBiryukov
7 years ago

Replying to ramiy:

I added a target="_blank" to the other file.

I'd prefer not to add any new target="_blank" attributes to links that don't currently have it, see #23432.

Looks good otherwise.

Last edited 7 years ago by SergeyBiryukov (previous) (diff)

#6 @ramiy
7 years ago

Excellent, I'll remove target="_blank". This ticket will focus only on string changes.

#7 @ramiy
7 years ago

@SergeyBiryukov

While updating the patch I noticed the accessibility text in wp-admin/includes/theme.php was changed.

#8 @SergeyBiryukov
7 years ago

Milestone 5.3
Resolution → duplicate
Status assigned → closed

Yep, looks like this was fixed in [45298] via #47158.

Note: See TracTickets for help on using tickets.

Download in other formats: