WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#47832 closed defect (bug) (fixed)

Post Publish Metabox: Replace @ with 'at' in the displayed date format

Reported by: birgire Owned by: audrasjb
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Date/Time Keywords: has-patch has-screenshots commit
Focuses: accessibility, administration Cc:

Description

This is a spin-off from ticket #44267

@afercia made a good case here:
https://core.trac.wordpress.org/ticket/44267#comment:10

Not sure using @ adds any value. Instead, I doubt it's announced correctly from assistive technologies in other languages. In Italian, for example, the @ symbol is called chiocciola and its main meaning is "snail" :) Or it's a particular type of stairs.
Firefox and NVDA do read out @ as "chiocciola". This makes sense only in the context of email addresses, where we usually say "xyx chiocciola xyz.com". However, "chiocciola" doesn't make any sense in the context of a date format. I guess this happens also in many other languages.
I guess only in English there's an association between the @ symbol and the word at. I'd tend to think @ doesn't have an universal meaning in the context of dates and it shouldn't be used this way. I'd rather just use the word at like, for example, in the Comments screen.
We should also try to remove @ in all the places in WordPress where it's used for dates, but I guess it should be addressed in a separate ticket.

This ticket focuses only on the post publish metabox. Let's try this one out first and then we can look into the other cases, e.g. revisions.

Attachments (5)

before.jpg (23.3 KB) - added by birgire 2 years ago.
47832.diff (3.8 KB) - added by birgire 2 years ago.
after.png (22.5 KB) - added by birgire 2 years ago.
47832.2.diff (4.0 KB) - added by audrasjb 2 years ago.
Adding back the link to PHP Date documentation
47832.3.diff (3.8 KB) - added by afercia 2 years ago.

Download all attachments as: .zip

Change History (17)

@birgire
2 years ago

@birgire
2 years ago

@birgire
2 years ago

#1 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 5.3

Looks great to me :)

This ticket was mentioned in Slack in #accessibility by audrasjb. View the logs.


2 years ago

#3 @audrasjb
2 years ago

  • Keywords commit added
  • Owner set to audrasjb
  • Status changed from new to accepted

Hi,

As per today's accessibility bug scrub and after some testing, the patch works fine and still applies cleanly, so let's add the commit keyword :)

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


2 years ago

#5 @afercia
2 years ago

Related: #47893.

@audrasjb
2 years ago

Adding back the link to PHP Date documentation

#6 @audrasjb
2 years ago

@birgire, similarly than in #47893, I propose in 47832.2.diff to re-add the link to PHP Date documentation, so polyglots don't loose that information in the new translation string :)

#7 @birgire
2 years ago

yes, good idea, thanks @audrasjb

This ticket was mentioned in Slack in #core-datetime by rarst. View the logs.


2 years ago

#9 @afercia
2 years ago

  • Keywords needs-refresh added; commit removed

Looks like the patch doesn't apply cleanly any longer, after recent changes.

@afercia
2 years ago

#10 @afercia
2 years ago

  • Keywords commit added; needs-refresh removed

47832.3.diff refreshes the patch.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


2 years ago

#12 @SergeyBiryukov
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 46083:

Accessibility: Posts, Post Types: Replace @ with at in the displayed date format.

The @ symbol makes sense in the context of email addresses, but does not have a universal meaning in the context of dates.

Props birgire, afercia, audrasjb, SergeyBiryukov.
Fixes #47832.

Note: See TracTickets for help on using tickets.