WordPress.org

Make WordPress Core

Opened 3 weeks ago

Last modified 12 days ago

#48432 new defect (bug)

WordPress updates broken with proxy and non routed environment

Reported by: sooslaca Owned by:
Milestone: 5.2.5 Priority: normal
Severity: major Version: 5.2.4
Component: HTTP API Keywords:
Focuses: Cc:
PR Number:

Description (last modified by SergeyBiryukov)

Hi,

This change [46475] broke updates when you're using proxy and you don't have DNS resolution/routing for the outside world. (like corporate networks)

Issue came up with this url https://downloads.wordpress.org/plugin/multiple-domain.zip

parsed_url:

Array(
    [scheme] => https
    [host] => downloads.wordpress.org
    [path] => /plugin/multiple-domain.zip
)

I think it worked before because

if ( empty( $parsed_url['port'] ) ) {
   return $url;
}

returned the URL and not false.

I tested changing it back to $ip = false; and I was able to update plugins.

Change History (3)

#1 @SergeyBiryukov
3 weeks ago

  • Component changed from General to HTTP API
  • Description modified (diff)
  • Milestone changed from Awaiting Review to 5.2.5

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


13 days ago

#3 @SergeyBiryukov
12 days ago

#48509 was marked as a duplicate.

Note: See TracTickets for help on using tickets.