WordPress.org

Make WordPress Core

Opened 12 months ago

Last modified 3 weeks ago

#48432 new defect (bug)

WordPress updates broken with proxy and non routed environment

Reported by: sooslaca Owned by:
Milestone: Future Release Priority: normal
Severity: major Version: 5.2.4
Component: HTTP API Keywords:
Focuses: Cc:

Description (last modified by SergeyBiryukov)

Hi,

This change [46475] broke updates when you're using proxy and you don't have DNS resolution/routing for the outside world. (like corporate networks)

Issue came up with this url https://downloads.wordpress.org/plugin/multiple-domain.zip

parsed_url:

Array(
    [scheme] => https
    [host] => downloads.wordpress.org
    [path] => /plugin/multiple-domain.zip
)

I think it worked before because

if ( empty( $parsed_url['port'] ) ) {
   return $url;
}

returned the URL and not false.

I tested changing it back to $ip = false; and I was able to update plugins.

Change History (10)

#1 @SergeyBiryukov
12 months ago

  • Component changed from General to HTTP API
  • Description modified (diff)
  • Milestone changed from Awaiting Review to 5.2.5

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


12 months ago

#3 @SergeyBiryukov
12 months ago

#48509 was marked as a duplicate.

#4 @dd32
11 months ago

#48509 was marked as a duplicate.

#5 @dd32
11 months ago

#48761 was marked as a duplicate.

#6 @SergeyBiryukov
10 months ago

  • Milestone changed from 5.2.5 to 5.4

#7 follow-up: @audrasjb
8 months ago

  • Milestone changed from 5.4 to Future Release

Hi,

With 5.4 Beta 3 approaching and the Beta period reserved for bugs introduced during the cycle, this is being moved to Future Release. If any maintainer or committer feels this should be included or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

#8 in reply to: ↑ 7 @karlte
7 months ago

Replying to audrasjb:

Hi,

With 5.4 Beta 3 approaching and the Beta period reserved for bugs introduced during the
cycle, this is being moved to Future Release. If any maintainer or committer feels this
should be included or wishes to assume ownership during a specific cycle, feel free to
update the milestone accordingly.

Hi audrasjb]!

The consequence would be, that everbody, who uses WP behind a firewall (and believe me,
there are many people doing this) has problems with any update, plugin or theme.

It ist only one line (!!), which has to be changed.

Hence it should be a good idea, the make this change now.

I'm only a WPUser and not meber of the the developer team, therefore i only
have the strenuous appeal, that should change this.

---
Grettings karlte

This ticket was mentioned in Slack in #core by madko77. View the logs.


3 weeks ago

#10 @madko77
3 weeks ago

Hi,

I had to revert https://core.trac.wordpress.org/changeset/46475 to make wordpress 5.5.x works behind proxy.

Best regards,
Edouard

Note: See TracTickets for help on using tickets.