WordPress updates broken with proxy and non routed environment

[sooslaca]

Hi,

This change [46475] broke updates when you're using proxy and you don't have DNS resolution/routing for the outside world. (like corporate networks)

Issue came up with this url ​https://downloads.wordpress.org/plugin/multiple-domain.zip

parsed_url:

Array(
    [scheme] => https
    [host] => downloads.wordpress.org
    [path] => /plugin/multiple-domain.zip
)

I think it worked before because

if ( empty( $parsed_url['port'] ) ) {
   return $url;
}

returned the URL and not false.

I tested changing it back to $ip = false; and I was able to update plugins.

[SergeyBiryukov]

#48509 was marked as a duplicate.

[dd32]

#48509 was marked as a duplicate.

[dd32]

#48761 was marked as a duplicate.

[audrasjb]

Hi,

With 5.4 Beta 3 approaching and the Beta period reserved for bugs introduced during the cycle, this is being moved to Future Release. If any maintainer or committer feels this should be included or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

[karlte]

Replying to audrasjb:

Hi,

With 5.4 Beta 3 approaching and the Beta period reserved for bugs introduced during the
cycle, this is being moved to Future Release. If any maintainer or committer feels this
should be included or wishes to assume ownership during a specific cycle, feel free to
update the milestone accordingly.

Hi audrasjb]!

The consequence would be, that everbody, who uses WP behind a firewall (and believe me,
there are many people doing this) has problems with any update, plugin or theme.

It ist only one line (!!), which has to be changed.

Hence it should be a good idea, the make this change now.

I'm only a WPUser and not meber of the the developer team, therefore i only
have the strenuous appeal, that should change this.

---
Grettings karlte

[madko77]

Hi,

I had to revert https://core.trac.wordpress.org/changeset/46475 to make wordpress 5.5.x works behind proxy.

Best regards,
Edouard

[karlte]

Replying to madko77:

Hi,

I had to revert https://core.trac.wordpress.org/changeset/46475 to make wordpress 5.5.x works behind proxy.

Best regards,
Edouard

[karlte]

Hi Edouardo!

Thanks for your note.

After a long time i just check WP 5.8 for this error.
The bug is still alive :-)

Nobody fixed it. I'll try to open a new ticket.
--
Best regards

karlte

[SergeyBiryukov]

#53880 was marked as a duplicate.

[SergeyBiryukov]

#48495 was marked as a duplicate.