Make WordPress Core

Opened 11 months ago

Closed 8 months ago

#48490 closed enhancement (fixed)

Login failure "shake" should use CSS animation

Reported by: markjaquith Owned by: markjaquith
Milestone: 5.4 Priority: normal
Severity: trivial Version:
Component: Login and Registration Keywords: has-patch
Focuses: ui, administration Cc:

Description (last modified by markjaquith)

The login failure "shake" uses really terrible old JavaScript to simulate the shake by moving the box. It's "choppy" by design. We have much better options now, like CSS animations.

Attachments (2)

48490.diff (2.0 KB) - added by markjaquith 11 months ago.
48490.1.diff (1.9 KB) - added by valentinbora 8 months ago.
Fix indentation upon 48490.diff in src/wp-login.php

Download all attachments as: .zip

Change History (8)

11 months ago

#1 @markjaquith
11 months ago

48490.diff is a much simpler and faster implementation, using translateX()

#2 @markjaquith
11 months ago

  • Description modified (diff)
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 5.4

8 months ago

Fix indentation upon 48490.diff in src/wp-login.php

#3 @valentinbora
8 months ago

Confirmed @markjaquith's patch functionality, good job.

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.

8 months ago

#5 @SergeyBiryukov
8 months ago

  • Component changed from Administration to Login and Registration

#6 @SergeyBiryukov
8 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 47226:

Login and Registration: Use CSS animation instead of old JavaScript code for "shake" animation on login failure.

Props markjaquith, valentinbora.
Fixes #48490.

Note: See TracTickets for help on using tickets.