Context Navigation

← Previous Ticket
Next Ticket →

#49317 closed defect (bug) (fixed)

Coding Standard : src/js/_enqueues/wp/media/editor.js

Reported by:	ankitmaru	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	5.4
Component:	Media	Version:	5.3.2
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:	javascript, coding-standards

Description

Javascript Coding Standard : src/js/_enqueues/wp/media/editor.js

Attachments (1)

Javascript_Coding_Standards.patch (1.7 KB ) - added by ankitmaru 6 years ago.

Download all attachments as: .zip

Change History (6)

@ankitmaru
6 years ago

Attachment Javascript_Coding_Standards.patch added

#1 @pasttenses
6 years ago

#2 @SergeyBiryukov
6 years ago

Milestone Awaiting Review → 5.4
Owner set to SergeyBiryukov
Status new → reviewing

#3 @audrasjb
6 years ago

Hi there,

With Beta 3 approaching, we'll need a decision and a commit action very soon.
For Component maintainers: if you don't feel the current patch is ready to land in WP 5.4 in the next few day, it's could be better to move it to 5.5. We're leaving it in the milestone for now.

#4 @SergeyBiryukov
6 years ago

Resolution → fixed
Status reviewing → closed

In 47349:

Coding Standards: Add missing braces to if conditions and use strict comparison in js/_enqueues/wp/media/editor.js.

Props ankitmaru.
Fixes #49317.

#5 @SergeyBiryukov
6 years ago

#49031 was marked as a duplicate.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#49317 closed defect (bug) (fixed)

Coding Standard : src/js/_enqueues/wp/media/editor.js

Description

Attachments (1)

Change History (6)

@ankitmaru 6 years ago

#1 @pasttenses 6 years ago

#2 @SergeyBiryukov 6 years ago

#3 @audrasjb 6 years ago

#4 @SergeyBiryukov 6 years ago

#5 @SergeyBiryukov 6 years ago