WordPress.org

Make WordPress Core

Opened 13 months ago

Closed 7 weeks ago

#49720 closed defect (bug) (fixed)

The Docker-based local environment should install the WordPress Importer plugin

Reported by: johnbillion Owned by: desrosj
Milestone: 5.7 Priority: normal
Severity: normal Version: 5.3
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description (last modified by johnbillion)

Setting up the Docker-based local environment on a fresh installation and running the tests results in failures due to the missing WordPress Importer plugin.

The npm run env:install command should also install the appropriate version of the WordPress Importer plugin in the local environment.

Failures:

1) Tests_Import_Import::test_small_import
This test requires the WordPress Importer plugin to be installed in the test suite. See: https://make.wordpress.org/core/handbook/contribute/git/#unit-tests

/var/www/tests/phpunit/tests/import/import.php:23

2) Tests_Import_Import::test_double_import
This test requires the WordPress Importer plugin to be installed in the test suite. See: https://make.wordpress.org/core/handbook/contribute/git/#unit-tests

/var/www/tests/phpunit/tests/import/import.php:23

3) Tests_Import_Import::test_ordering_of_importers
This test requires the WordPress Importer plugin to be installed in the test suite. See: https://make.wordpress.org/core/handbook/contribute/git/#unit-tests

/var/www/tests/phpunit/tests/import/import.php:23

4) Tests_Import_Import::test_slashes_should_not_be_stripped
This test requires the WordPress Importer plugin to be installed in the test suite. See: https://make.wordpress.org/core/handbook/contribute/git/#unit-tests

/var/www/tests/phpunit/tests/import/import.php:23

5) Tests_Import_Parser::test_malformed_wxr
This test requires the WordPress Importer plugin to be installed in the test suite. See: https://make.wordpress.org/core/handbook/contribute/git/#unit-tests

/var/www/tests/phpunit/tests/import/parser.php:21

6) Tests_Import_Parser::test_invalid_wxr
This test requires the WordPress Importer plugin to be installed in the test suite. See: https://make.wordpress.org/core/handbook/contribute/git/#unit-tests

/var/www/tests/phpunit/tests/import/parser.php:21

7) Tests_Import_Parser::test_wxr_version_1_1
This test requires the WordPress Importer plugin to be installed in the test suite. See: https://make.wordpress.org/core/handbook/contribute/git/#unit-tests

/var/www/tests/phpunit/tests/import/parser.php:21

8) Tests_Import_Parser::test_wxr_version_1_0
This test requires the WordPress Importer plugin to be installed in the test suite. See: https://make.wordpress.org/core/handbook/contribute/git/#unit-tests

/var/www/tests/phpunit/tests/import/parser.php:21

9) Tests_Import_Parser::test_escaped_cdata_closing_sequence
This test requires the WordPress Importer plugin to be installed in the test suite. See: https://make.wordpress.org/core/handbook/contribute/git/#unit-tests

/var/www/tests/phpunit/tests/import/parser.php:21

10) Tests_Import_Parser::test_unescaped_cdata_closing_sequence
This test requires the WordPress Importer plugin to be installed in the test suite. See: https://make.wordpress.org/core/handbook/contribute/git/#unit-tests

/var/www/tests/phpunit/tests/import/parser.php:21

11) Tests_Import_Postmeta::test_serialized_postmeta_no_cdata
This test requires the WordPress Importer plugin to be installed in the test suite. See: https://make.wordpress.org/core/handbook/contribute/git/#unit-tests

/var/www/tests/phpunit/tests/import/postmeta.php:21

12) Tests_Import_Postmeta::test_utw_postmeta
This test requires the WordPress Importer plugin to be installed in the test suite. See: https://make.wordpress.org/core/handbook/contribute/git/#unit-tests

/var/www/tests/phpunit/tests/import/postmeta.php:21

13) Tests_Import_Postmeta::test_serialized_postmeta_with_cdata
This test requires the WordPress Importer plugin to be installed in the test suite. See: https://make.wordpress.org/core/handbook/contribute/git/#unit-tests

/var/www/tests/phpunit/tests/import/postmeta.php:21

14) Tests_Import_Postmeta::test_serialized_postmeta_with_evil_stuff_in_cdata
This test requires the WordPress Importer plugin to be installed in the test suite. See: https://make.wordpress.org/core/handbook/contribute/git/#unit-tests

/var/www/tests/phpunit/tests/import/postmeta.php:21

Change History (8)

#1 @johnbillion
13 months ago

  • Description modified (diff)

#2 @TimothyBlynJacobs
11 months ago

In 47811:

REST API: Add @since entries for rest_validate_value_from_schema().

See #49572, #48818, #44949, #50053, #48820, #49720, #42961, #44975, #43392, #38583.

This ticket was mentioned in PR #987 on WordPress/wordpress-develop by desrosj.


2 months ago

  • Keywords has-patch added; needs-patch removed

Trac ticket:

#4 @desrosj
2 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 50285:

Build/Test Tools: Install WordPress Importer plugin when installing the Docker-based local environment.

The WordPress Importer plugin is now downloaded to the tests/phpunit/data/plugins directory when running npm run env:install.

This ensures that the PHPUnit test suite will not fail when the plugin is missing.

This also introduces a new WP_IMPORTER_REVISION variable to the .env file, to control the SVN revision that is checked out.

Props johnbillion.
Fixes #49720.

#5 @desrosj
2 months ago

  • Milestone changed from Awaiting Review to 5.7
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to backport.

This ticket was mentioned in Slack in #core by sergey. View the logs.


2 months ago

#8 @desrosj
7 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.