Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#50549 closed enhancement (fixed)

Remove use of "normal" in user-facing output

Reported by: dartiss's profile dartiss Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Text Changes Keywords:
Focuses: Cc:


A minor text change to remove two instances of where the exclusive word "normal" is used on screen output.

A separate ticket will be logged for changing the use of this word in comments (which is a much bigger ask).

Attachments (2)

50549.diff (2.3 KB) - added by dartiss 3 years ago.
50549-2.diff (870 bytes) - added by dartiss 3 years ago.

Download all attachments as: .zip

Change History (7)

3 years ago

3 years ago

#1 @dartiss
3 years ago

This is my first attempt at providing diff changes, so apologies if there is any issue with this - happy for guidance and to add any required changes.

#2 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 5.5

Thanks for the patches!

The new Site Health strings in 50549.diff do seem like an improvement.

I'm less sure about 50549-2.diff. Could you clarify what's wrong with "your site will return to normal"?

#3 @dartiss
3 years ago

Thanks for the question.

Let me give an example. What if the upgrade breaks something? It won't return to how it was before, which is what most people might define as "normal". Instead, this wording clarifies exactly what it means - that once it's complete, maintenance mode will be switched off.

Apart from the fact that "normal" is generally seen as a troublesome word, in this case it's suggesting more than it can promise.

#4 @SergeyBiryukov
3 years ago

Thanks, all good points.

#5 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 48287:

Text Changes: Remove use of "normal" in user-facing output.

This clarifies some messages referring to Site Health checks and maintenance mode, and makes them more accurate.

Props dartiss.
Fixes #50549.

Note: See TracTickets for help on using tickets.