WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 2 months ago

#50550 closed task (blessed) (fixed)

Block Editor: Backport the initial set of block patterns from the Gutenberg Plugin.

Reported by: youknowriad Owned by: youknowriad
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch
Focuses: Cc:

Description

This ticket tracks the backporting of the set of blocks patterns to load by default in Gutenberg Core.

While the design team still expects to make some final calls after beta1 about what block patterns to include/exclude. It is important to have an initial set ready for beta1.

Adding/Removing patterns after beta1 is fine since they don't have any impact on APIs or bug fixes but it is important that we're done before the string freeze to make sure these are translated properly.

Attachments (1)

50550-doing-it-wrong.patch (1.4 KB) - added by poena 3 months ago.
Require the title and content properties, add doing it wrong message.

Download all attachments as: .zip

Change History (12)

This ticket was mentioned in PR #385 on WordPress/wordpress-develop by youknowriad.


3 months ago

  • Keywords has-patch added

This ticket was mentioned in Slack in #core-editor by youknowriad. View the logs.


3 months ago

#3 @mcsf
3 months ago

I left a question at https://github.com/WordPress/wordpress-develop/pull/385#discussion_r450117480. Regardless, this seems good to go.

#4 @youknowriad
3 months ago

In 48334:

Block Editor: Add the initial set of block patterns.

Included patterns:

text-two-columns
two-buttons
two-images
text-two-columns-with-images
text-three-columns-buttons
large-header
large-header-paragraph
three-buttons
quote
testimonials

Props mcsf, nrqsnchz.
See #50550.

#5 @poena
3 months ago

Are the testimonials meant to be included here? They were removed from the plugin.

#6 @youknowriad
3 months ago

Good catch @poena I did the patch before they were removed from the plugin, I can remove them here too for the moment.

#7 @youknowriad
3 months ago

In 48335:

Block Editor: Remove the Testimonials block pattern.

This ensures we have the same patterns used in the Gutenberg plugin.

Props poena.
See #50550.

@poena
3 months ago

Require the title and content properties, add doing it wrong message.

#8 @youknowriad
3 months ago

In 48336:

Block Editor: Requires title and content when registering block patterns.

Props poena.
See #50550.

#9 @desrosj
3 months ago

In 48345:

Coding Standards: Correct two coding standards issues introduced in [48277] and [48334].

See #50504, #50550.

#11 @youknowriad
2 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 48639:

Block Editor: Update the Core Block Patterns.

Backport the latest block patterns from the Gutenberg plugin.
The new patterns adapt properly to Core themes.

Props nrqsnchz.
Fixes #50550, #50594.

Note: See TracTickets for help on using tickets.