WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 2 months ago

Last modified 2 months ago

#50594 closed task (blessed) (fixed)

Ensure new default block patterns are styled correctly in default themes

Reported by: desrosj Owned by: youknowriad
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: needs-screenshots
Focuses: Cc:

Description

WordPress 5.5 will see the introduction of the block pattern API with several patterns included with core by default. The default patterns are currently planned as follows:

  • text-two-columns
  • two-buttons
  • two-images
  • text-two-columns-with-images
  • text-three-columns-buttons
  • large-header
  • large-header-paragraph
  • three-buttons
  • quote

Each default theme should be adjusted if necessary to properly display these patterns both in the editor and on the front end.

See #50550 for the introduction of block patterns in Core.

Attachments (3)

two-buttons-preview.png (3.2 KB) - added by justinahinon 3 months ago.
two-buttons-in-editor.png (4.4 KB) - added by justinahinon 3 months ago.
themes-tests.jpg (2.5 MB) - added by nrqsnchz 2 months ago.

Change History (16)

#1 @justinahinon
3 months ago

On Twenty Ten, all the default patterns look fine (front and backend) except the two buttons pattern. The default color of the first button make it not lisible at all in the pattern preview and in the editor.



I suspect this to be because of default color that is applied in all elements in the editor

.editor-styles-wrapper * {
    color: #444;
}

in develop.svn.wordpress.org/trunk/src/wp-http://develop.svn.wordpress.org/trunk/src/wp-content/themes/twentyten/editor-style.css #L9

#2 follow-up: @joyously
3 months ago

Shouldn't this ticket be on the editor, not the themes? Patterns supplied by core should just work for any theme. The theme shouldn't have to "keep up" and change styles for a new pattern. How could that possibly be sustainable?

#3 in reply to: ↑ 2 @desrosj
3 months ago

Replying to joyously:

Shouldn't this ticket be on the editor, not the themes? Patterns supplied by core should just work for any theme. The theme shouldn't have to "keep up" and change styles for a new pattern. How could that possibly be sustainable?

Patterns supplied by Core will work, but the editor cannot account for styles in themes that override Core block styling, (unless !important is used heavily, and that's not the right solution), and nor should they. The editor also cannot account for the aesthetics of every theme.

Regardless of what changes are included in a release, every plugin and theme author should always be testing for bugs as new releases become available. It's possible this testing reveals a bug or improvement that can be made in the editor code. But that's what testing is for.

This ticket is to test and verify that the block patterns will work correctly and look natural within each default bundled theme. Because these are the themes that have or will ship with WordPress by default, we have a responsibility to the user base to maintain these themes as best we can. But that's why there is a Bundled Theme component with maintainers.

Based on @justinahinon's testing of Twenty Ten above, there are only a two patterns with issues. I expect this to be the case with each theme (one or two with an issue).

#4 @joyously
3 months ago

The thing that was pointed out should be fixed in the editor, not the theme.

#5 @poena
2 months ago

Hi, are the block patterns now final so that we can test?

This ticket was mentioned in Slack in #core-editor by desrosj. View the logs.


2 months ago

#7 @youknowriad
2 months ago

The block patterns in the plugin are close to a final stage for 5.5.
The last update is planned on trunk before the RC1 release. it's tracked here #50550

#8 @nrqsnchz
2 months ago

I'm still doing one last round of polish based on feedback I've received. I'll update here once I've finalized that.

This ticket was mentioned in Slack in #core by whyisjake. View the logs.


2 months ago

#10 @nrqsnchz
2 months ago

All updates and polish to block patterns have finalized, last one was merged a couple of hours ago.

I went ahead and tested the patterns in the last ten core default themes, from Twenty twenty to Twenty ten.

I'm attaching an image with all of these laid out next to each other for better comparison.

#11 @youknowriad
2 months ago

  • Owner set to youknowriad
  • Resolution set to fixed
  • Status changed from new to closed

In 48639:

Block Editor: Update the Core Block Patterns.

Backport the latest block patterns from the Gutenberg plugin.
The new patterns adapt properly to Core themes.

Props nrqsnchz.
Fixes #50550, #50594.

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


2 months ago

This ticket was mentioned in Slack in #core-editor by nrqsnchz. View the logs.


2 months ago

Note: See TracTickets for help on using tickets.