WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#51441 closed defect (bug) (fixed)

Add brackets to @see tags

Reported by: ravipatel's profile ravipatel Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.6 Priority: low
Severity: normal Version: 5.6
Component: General Keywords: has-patch
Focuses: docs, coding-standards Cc:

Description

Cannot be resolved to a type value fixed.

Attachments (3)

51441-general-template.php.patch​ (515 bytes) - added by ravipatel 4 years ago.
cannot be resolved to a type - document chages
51441.patch​ (971 bytes) - added by ravipatel 4 years ago.
Merge 2 files patches with same issue
51441-multiple-files.patch​ (3.5 KB) - added by ravipatel 4 years ago.
Added with multiples files code

Download all attachments as: .zip

Change History (8)

@ravipatel
4 years ago

cannot be resolved to a type - document chages

@ravipatel
4 years ago

Merge 2 files patches with same issue

This ticket was mentioned in ​Slack in #core by ravi. ​View the logs.
4 years ago

#2 @davidbaumwald
4 years ago

  • Keywords needs-refresh added
  • Priority changed from normal to low

@ravipatel Can you refresh these patches against the src? The patch does not include the file path and is more difficult to apply. For instance, shortcodes.php should be src/wp-includes/shortcodes.php.

Here's a Handbook page about creating the patch from src/ ​https://make.wordpress.org/core/handbook/tutorials/trac/submitting-a-patch/

@ravipatel
4 years ago

Added with multiples files code

#3 @davidbaumwald
4 years ago

  • Focuses docs added
  • Keywords needs-refresh removed

@ravipatel Third-party packages, like SimplePie, are imported to the codebase as-is, so they don't have to be updated to the WPCS. The other changes to other files look good though.

#4 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 5.6
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing
  • Summary changed from Cannot be resolved to a type. to Add brackets to @see tags

#5 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 49092:

Docs: Add brackets to function names in some @see tags, for consistency.

Props ravipatel, davidbaumwald.
Fixes #51441.

Note: See TracTickets for help on using tickets.