WordPress.org

Make WordPress Core

Opened 7 weeks ago

Last modified 2 days ago

#51476 reviewing enhancement

When plugins are updating, the adminbar icon should also rotate

Reported by: johnjamesjacoby Owned by: SergeyBiryukov
Milestone: 5.7 Priority: normal
Severity: normal Version: 4.6
Component: Plugins Keywords: has-screenshots has-patch
Focuses: accessibility, javascript, css, rtl, administration Cc:

Description

When updating plugins on the Plugins screen using the new'ish fancy inline updating approach, an inline notice will appear with a rotating dashicon to signify that it is currently being updated.

I think it would be a nice bit of polish if the same dashicon in the adminbar also rotated at the same time, and stopped when all plugins are done updating.

Attachments (5)

jjj-sc-2020-10-07 at 16.02.22@2x.png (47.6 KB) - added by johnjamesjacoby 7 weeks ago.
51476.patch (1.7 KB) - added by ravipatel 7 weeks ago.
Updated a pathch with js & css code
51476-new.patch (1.5 KB) - added by ravipatel 7 weeks ago.
latest code
51476-update-plugin-icon.2.patch (3.0 KB) - added by ravipatel 7 weeks ago.
success & error based managed code.
51476-update-single-bulk.patch (3.2 KB) - added by ravipatel 7 weeks ago.
Added New code for a single & bulk action : Update

Download all attachments as: .zip

Change History (19)

#1 @johnbillion
7 weeks ago

  • Focuses css added

@ravipatel
7 weeks ago

Updated a pathch with js & css code

#2 @ravipatel
7 weeks ago

  • Keywords has-patch added
  • Version set to trunk

@ravipatel
7 weeks ago

latest code

This ticket was mentioned in Slack in #core by ravi. View the logs.


7 weeks ago

#4 @ravipatel
7 weeks ago

  • Focuses javascript rtl added

@ravipatel
7 weeks ago

success & error based managed code.

This ticket was mentioned in Slack in #core-css by ryelle. View the logs.


7 weeks ago

#6 @ryelle
7 weeks ago

  • Keywords needs-design-feedback added

This came up in the CSS bug scrub today, and we decided it could use a designer's input.

#7 @johnjamesjacoby
7 weeks ago

If it helps, I came to the conclusion that this would be useful when updating several plugins at the same time, but without using the bulk updater.

Once I've scrolled away from a plugin and clicked to update another, there is no indication within the viewport that plugins are successfully or failing to update, other than the number being decremented on success.

Seeing the icon spin in the adminbar seems like a logical way, to me, to communicate to users that something is still processing somewhere on the page.

@ravipatel
7 weeks ago

Added New code for a single & bulk action : Update

This ticket was mentioned in Slack in #design by paaljoachim. View the logs.


4 weeks ago

#9 @paaljoachim
4 weeks ago

We discussed the ticket during a design feedback session and liked the idea of having a rotating spinner in the top admin bar. There was some additional discussion. Here is a link: https://wordpress.slack.com/archives/C02S78ZAL/p1603902566204600

One question came up. How would this behave on mobile?

It would be great with some newer screenshots. Thanks.

Last edited 2 days ago by paaljoachim (previous) (diff)

#10 @paaljoachim
4 weeks ago

  • Focuses accessibility added

#11 @hellofromTonya
2 weeks ago

  • Version changed from trunk to 4.6

The "updating plugins on the Plugins screen using the new'ish fancy inline updating approach" was added before 5.6. In talking with others, Ajax updates were in 4.6. Changing the version to 4.6.

However, if this version is not correct, please advise or update.

#12 @SergeyBiryukov
3 days ago

  • Keywords needs-design-feedback removed
  • Milestone changed from Awaiting Review to 5.7
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

Some design feedback was provided in comment:9, looks like this is good to go, assuming the patch works as expected.

This ticket was mentioned in Slack in #design by paaljoachim. View the logs.


2 days ago

Note: See TracTickets for help on using tickets.