Opened 4 years ago
Closed 3 weeks ago
#52303 closed defect (bug) (fixed)
Accessibility issues in revisions screen
Reported by: | joedolson | Owned by: | joedolson |
---|---|---|---|
Milestone: | 6.7 | Priority: | normal |
Severity: | normal | Version: | 3.6.1 |
Component: | Revisions | Keywords: | has-patch commit |
Focuses: | ui, accessibility, javascript | Cc: |
Description
In the course of assessing a functional problem with wp_text_diff
, a number of accessibility concerns were unearthed regarding the revisions screen.
Once the output of wp_text_diff
is settled, the other concerns noted in #25473 should be addressed here.
Attachments (1)
Change History (16)
This ticket was mentioned in Slack in #accessibility by hedgefield. View the logs.
4 years ago
#4
@
4 years ago
Issues that still need to be resolved in the Revisions screen:
1) Can this be reduced to a single table, so that a single set of headers ('Removed' and 'Added') can be displayed for all content, rather than having different sets for each type of data.
2) Add aria-labelledby and aria-describedby attributes to the view slider to improve the accessibility of navigating revisions.
3) Fix headings hierarchy (current H3 headings should be H2)
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
4 months ago
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
4 months ago
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
3 months ago
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
5 weeks ago
#10
@
5 weeks ago
After discussion in the accessibility bug scrub, we think that making the changes I suggested for headings hierarchy and the slider labeling are still worth doing and practical, but the larger change to collapse into a single table would not be a productive use of time.
This ticket was mentioned in PR #7483 on WordPress/wordpress-develop by @william.alexander.
5 weeks ago
#11
- Keywords has-patch added; needs-patch removed
Moving the aria label related code changes from https://core.trac.wordpress.org/attachment/ticket/25473/25473.diff to this PR.
Trac ticket: https://core.trac.wordpress.org/ticket/52303
@joedolson commented on PR #7483:
4 weeks ago
#12
Hi, @wmalexander! Thanks for this! I added some additional things that were missing, and made a few changes to how things were implemented.
If you can give this some further testing, it would be great! One thing that didn't work in my testing was the focus styles; but I think that's just because the cache wouldn't refresh when I rebuilt, for some reason.
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
4 weeks ago
#14
@
3 weeks ago
- Keywords commit added
Tested further, and confirmed that the labelling and headings changes work as expected. Modified slightly to omit Restore this revision
from the aria-labelledby
value, to avoid giving the impression that the slider handle also allows you to restore a revision.
No visual changes other than supporting a :focus
state on the slider which was previously missing.
Marking for commit.
Hey @joedolson Would you be able to list and summarize the final a11y to-do's from #25473 in the description? Thanks!