WordPress.org

Make WordPress Core

Opened 2 months ago

Last modified 7 weeks ago

#53261 reviewing defect (bug)

jQuery deprecated click function

Reported by: kapilpaul Owned by: SergeyBiryukov
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.8
Component: Media Keywords: has-patch
Focuses: javascript Cc:

Description

Hi,

In src/js/_enqueues/vendor/plupload/handlers.js jQuery click function is still there which is deprecated. Need to update this as per the new convention.

Attachments (2)

53261.diff (951 bytes) - added by kapilpaul 2 months ago.
Created patch.
53261.2.diff (963 bytes) - added by kapilpaul 2 months ago.
Created patch with updated coding standard.

Download all attachments as: .zip

Change History (7)

@kapilpaul
2 months ago

Created patch.

#1 @kapilpaul
2 months ago

  • Keywords has-patch added; needs-patch removed

@kapilpaul
2 months ago

Created patch with updated coding standard.

This ticket was mentioned in PR #1282 on WordPress/wordpress-develop by kapilpaul.


2 months ago

This PR will fix the deprecated jQuery click function in js/_enqueues/vendor/plupload/handlers.js

Trac ticket: https://core.trac.wordpress.org/ticket/53261

#3 follow-up: @Hareesh Pillai
8 weeks ago

Hi @kapilpaul, welcome to Core Trac. Thanks for the ticket and patch.

The deprecation is found in an external library - plupload. We normally do not update the external library files directly.

Having said that, the latest update of that library is not GPL anymore. See ticket:48277#comment:8 for details.

Because of this, we may have to consider fixing the bugs ourselves going forward, as per the comment by @azaozz. ticket:40158#comment:23

#4 in reply to: ↑ 3 @SergeyBiryukov
8 weeks ago

  • Milestone changed from Awaiting Review to 5.8
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

Replying to Hareesh Pillai:

The deprecation is found in an external library - plupload. We normally do not update the external library files directly.

Just noting that the js/_enqueues/vendor/plupload/handlers.js file specifically is a WordPress file and not an external dependency :)

#5 @hellofromTonya
7 weeks ago

  • Milestone changed from 5.8 to 5.9

Today is 5.8 Beta 1. As this ticket needs review, punting to 5.9.

Note: See TracTickets for help on using tickets.