Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#53261 closed defect (bug) (fixed)

jQuery deprecated click function

Reported by: kapilpaul's profile kapilpaul Owned by: joedolson's profile joedolson
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.8
Component: Media Keywords: has-patch commit
Focuses: javascript Cc:

Description

Hi,

In src/js/_enqueues/vendor/plupload/handlers.js jQuery click function is still there which is deprecated. Need to update this as per the new convention.

Attachments (3)

53261.diff (951 bytes) - added by kapilpaul 3 years ago.
Created patch.
53261.2.diff (963 bytes) - added by kapilpaul 3 years ago.
Created patch with updated coding standard.
53261.3.diff (860 bytes) - added by joedolson 3 years ago.
Refresh patch to base from trunk

Download all attachments as: .zip

Change History (13)

@kapilpaul
3 years ago

Created patch.

#1 @kapilpaul
3 years ago

  • Keywords has-patch added; needs-patch removed

@kapilpaul
3 years ago

Created patch with updated coding standard.

This ticket was mentioned in PR #1282 on WordPress/wordpress-develop by kapilpaul.


3 years ago
#2

This PR will fix the deprecated jQuery click function in js/_enqueues/vendor/plupload/handlers.js

Trac ticket: https://core.trac.wordpress.org/ticket/53261

#3 follow-up: @Hareesh Pillai
3 years ago

Hi @kapilpaul, welcome to Core Trac. Thanks for the ticket and patch.

The deprecation is found in an external library - plupload. We normally do not update the external library files directly.

Having said that, the latest update of that library is not GPL anymore. See ticket:48277#comment:8 for details.

Because of this, we may have to consider fixing the bugs ourselves going forward, as per the comment by @azaozz. ticket:40158#comment:23

#4 in reply to: ↑ 3 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 5.8
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

Replying to Hareesh Pillai:

The deprecation is found in an external library - plupload. We normally do not update the external library files directly.

Just noting that the js/_enqueues/vendor/plupload/handlers.js file specifically is a WordPress file and not an external dependency :)

#5 @hellofromTonya
3 years ago

  • Milestone changed from 5.8 to 5.9

Today is 5.8 Beta 1. As this ticket needs review, punting to 5.9.

This ticket was mentioned in Slack in #core-media by antpb. View the logs.


3 years ago

#7 @joedolson
3 years ago

  • Keywords commit added
  • Owner changed from SergeyBiryukov to joedolson
  • Status changed from reviewing to accepted

Github PR is good. Marking for commit.

#8 follow-up: @joedolson
3 years ago

@kapilpaul Just a quick note for future reference - you should always create patches from the trunk version of the code. Your second patch was created on top of the second patch, and that will cause it to be rejected, since the code it's changing only exists if you've already applied the first patch. It's not a big deal with a tiny patch like this one, but for larger changes it could be a significant hassle!

@joedolson
3 years ago

Refresh patch to base from trunk

#9 @joedolson
3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 51947:

Media: Remove deprecated click function in media uploader.

Replace the call to jQuery's deprecated click handler.

Props kapilpaul.
Fixes #53261.

#10 in reply to: ↑ 8 @kapilpaul
3 years ago

Replying to joedolson:

@kapilpaul Just a quick note for future reference - you should always create patches from the trunk version of the code. Your second patch was created on top of the second patch, and that will cause it to be rejected, since the code it's changing only exists if you've already applied the first patch. It's not a big deal with a tiny patch like this one, but for larger changes it could be a significant hassle!

Thank you joedolson for the heads up. I will keep in mind from the next time.

Note: See TracTickets for help on using tickets.