The value of the `post_count` meta field is wrong because it doesn't get decremented when a post is deleted

[henry.wright]

The update_posts_count() function is used to update a blog's post count. When a post is added to the database the post_count value is incremented as expected. However, when a post is deleted, the post_count value isn't decremented.

This is because the _update_posts_count_on_delete() function, which calls update_posts_count() is hooked to the delete_post action.

delete_post fires immediately before a post is deleted from the database.

Therefore, the query performed in update_posts_count() to get the post count is run at the wrong time.

The solution is to use the deleted_post hook instead of the delete_post hook.

[henry.wright]

53443.diff uses the deleted_post hook instead of the delete_post hook

[hellofromTonya]

Hmm the change makes sense to me. Marking as needs-testing to ensure reproducible and then fixed after the patch. A test report will be helpful.

Trac ticket: [](https://core.trac.wordpress.org/ticket/53443)

[pbearne]

the change the filter does fix this

[pbearne]

I am confused why the tests are failing on github as the test is passing in my local

It looks like the last commit (moving the action from deleted_post to after_delete_post) fixes the issue. It also makes sense to me since now caches are refreshed before assuming the delete action is done.

(the multisite testing report look unrelated)

[henry.wright]

For the failing tests, do we need to create a blog and switch to it before the assertions are run?

$blog_id = self::factory()->blog->create();
switch_to_blog( $blog_id );

[audrasjb]

@henrywright it sounded like a good idea, but the tests are failing as well :)

[henry.wright]

In that case the problem could be the array argument passed to the create() method.

array(
    'post_type'   => 'post',
    'post_author' => '1',
    'post_date'   => '2012-10-23 19:34:42',
)

This will likely be creating a post in draft status because the default value for post_status is draft.

We could try explicitly setting the post_status value to publish. update_posts_count() gets a count of published posts only to set the post count.

array(
    'post_type'   => 'post',
    'post_author' => '1',
    'post_date'   => '2012-10-23 19:34:42',
    'post_status' => 'publish',
)

[henry.wright]

Also when a new WordPress blog is created, it is automatically populated with Hello world! post. Do we need to account for that post in the assertion?

[henry.wright]

Actually, I can see the automatically populated Hello world! post is already accounted for

@audrasjb tests still failing now ​b17e1e7 is applied means the value of post_count isn't incremented when the Hello world! post is created during blog creation

The Hello world! post is inserted using $wpdb methods instead of going through the wp_insert_post() API. Because the API isn't used, update_posts_count() isn't called. This results in the assertion failing because the expected value is erroneously 1. The expected value should be, and would be, 2 if the Hello world! post incremented post_count.

I'll post the specific test failure below for easy reference:

There was 1 failure:

1) Tests_update_posts_count_on_delete::test_update_posts_count_on_delete
post added
Failed asserting that 2 matches expected 1.

/var/www/tests/phpunit/tests/multisite/ms-functions/update_posts_count.php:38

Alright, let's try to take into account the "Hello World" blog post automatically created with the blog then.

Yay tests are passing

1 final amendment I'd suggest is add a call to restore_current_blog() at the end of the routine because we added a switch_to_blog() call at the start

[audrasjb]

Tests are passing now. Self-assigning for commit consideration.

[henry.wright]

Related #54462

[audrasjb]

In 52201:

Posts, Post Types: Increment post_count option value during blog creation.

Previously, the post_count option value was not incremented when the default "Hello world!" post is inserted during blog creation on a multisite installation.

Props henry.wright.
Fixes #54462.
See #53443.

[audrasjb]

Now that #54462 is closed, let's refresh the unit tests.

[henry.wright]

Now that #54462 is closed, let's refresh the unit tests.

Cool

@henrywright the code is updated. Tests are passing.
I think we're good to go now, isn't it?

Trac ticket: https://core.trac.wordpress.org/ticket/53443

[audrasjb]

@henrywright @pbearne I added a new PR to rename the new unit test file from update_posts_count.php to updatePostsCount.php for better consistency with the other test files in this folder.

[henry.wright]

The new PR ​1912 is looking good

[audrasjb]

In 52207:

Posts, Post Types: Multisite: Decrement post_count option value when a post is deleted.

Previously, the post_count option value was not decremented when a post was deleted.

This change moves the _update_posts_count_on_delete action from delete_post hook to after_delete_post to ensure the deletion is taken into account.

Props henry.wright, pbearne, audrasjb.
Fixes #53443.

Committed in https://core.trac.wordpress.org/changeset/52207

Committed via https://core.trac.wordpress.org/changeset/52207.