Opened 5 years ago
Closed 5 years ago
#53764 closed defect (bug) (fixed)
Remove unused code from media.php file
| Reported by: | rudlinkon | Owned by: | hellofromTonya |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.9 |
| Component: | Media | Version: | 5.9 |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | Focuses: | coding-standards |
Description
<?php // media_upload_form( $errors ); ?>
I've seen there are two places where the above code is keeping but those codes are commented so not in use.
Repository: wordpress-develop
Branch: master
Line Numbers: 2580 and 2882
File Path: /wp-admin/includes/media.php
Attachments (1)
Change History (6)
#2
@
5 years ago
- Component General → Media
- Keywords has-copy-review removed
- Milestone Awaiting Review → 5.9
#4
in reply to: ↑ 3
@
5 years ago
Replying to hellofromTonya:
Thank you so much for your kind information @hellofromTonya
Hello @rudlinkon,
Welcome to WordPress Core Trac! Thank you for this creating this ticket and submitting a patch.
Both instances were introduced in ticket #5911 with changesets [7043] and [7062] back in 2008. No reasons shared in the ticket or code why they were commented out. I didn't find changesets were they were reverted and made active.
53764.patch looks good to me. Seems safe to remove both. Will mark for
commitconsideration.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Hello @rudlinkon,
Welcome to WordPress Core Trac! Thank you for this creating this ticket and submitting a patch.
Both instances were introduced in ticket #5911 with changesets [7043] and [7062] back in 2008. No reasons shared in the ticket or code why they were commented out. I didn't find changesets were they were reverted and made active.
53764.patch looks good to me. Seems safe to remove both. Will mark for
commitconsideration.