Opened 3 years ago
Closed 3 years ago
#53764 closed defect (bug) (fixed)
Remove unused code from media.php file
Reported by: | rudlinkon | Owned by: | hellofromTonya |
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | 5.9 |
Component: | Media | Keywords: | has-patch commit |
Focuses: | coding-standards | Cc: |
Description
<?php // media_upload_form( $errors ); ?>
I've seen there are two places where the above code is keeping but those codes are commented so not in use.
Repository: wordpress-develop
Branch: master
Line Numbers: 2580 and 2882
File Path: /wp-admin/includes/media.php
Attachments (1)
Change History (6)
#2
@
3 years ago
- Component changed from General to Media
- Keywords has-copy-review removed
- Milestone changed from Awaiting Review to 5.9
#3
follow-up:
↓ 4
@
3 years ago
- Keywords commit added
- Owner set to hellofromTonya
- Status changed from new to accepted
#4
in reply to:
↑ 3
@
3 years ago
Replying to hellofromTonya:
Thank you so much for your kind information @hellofromTonya
Hello @rudlinkon,
Welcome to WordPress Core Trac! Thank you for this creating this ticket and submitting a patch.
Both instances were introduced in ticket #5911 with changesets [7043] and [7062] back in 2008. No reasons shared in the ticket or code why they were commented out. I didn't find changesets were they were reverted and made active.
53764.patch looks good to me. Seems safe to remove both. Will mark for
commit
consideration.
Hello @rudlinkon,
Welcome to WordPress Core Trac! Thank you for this creating this ticket and submitting a patch.
Both instances were introduced in ticket #5911 with changesets [7043] and [7062] back in 2008. No reasons shared in the ticket or code why they were commented out. I didn't find changesets were they were reverted and made active.
53764.patch looks good to me. Seems safe to remove both. Will mark for
commit
consideration.