WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 4 months ago

#53799 closed defect (bug) (fixed)

Remove version-controlled files check from Test Old Branches workflow

Reported by: desrosj Owned by: desrosj
Milestone: 5.8.1 Priority: normal
Severity: normal Version: 5.8
Component: Build/Test Tools Keywords: fixed-major
Focuses: Cc:

Description

The Test Old Branches workflow is used to dispatch workflow runs for old branches because GitHub does not support the schedule event outside of the default branch.

After [51355], has started failing. Since the repository is not checked out in this workflow, the git diff step returns an error. This check can be removed from this workflow.

Change History (3)

#1 @desrosj
4 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 51498:

Build/Test Tools: Remove the check for changes to version-controlled files in the Test Old Branch workflow.

This workflow does not perform a git checkout and is only used to dispatch workflows for old branches, so this check is not needed here.

Fixes #53799.

#2 @desrosj
4 months ago

  • Keywords fixed-major added
  • Milestone changed from 5.9 to 5.8.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

Going to backport this since it was added in 5.8 so that the workflow is consistent in all branches going forward.

#3 @desrosj
4 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 51502:

Build/Test Tools: Remove the check for changes to version-controlled files in the Test Old Branch workflow.

This workflow does not perform a git checkout and is only used to dispatch workflows for old branches, so this check is not needed here.

Merges [51498] to the 5.8 branch.
Fixes #53799.

Note: See TracTickets for help on using tickets.