WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#53799 closed defect (bug) (fixed)

Remove version-controlled files check from Test Old Branches workflow

Reported by: desrosj Owned by: desrosj
Priority: normal Milestone: 5.8.1
Component: Build/Test Tools Version: 5.8
Severity: normal Keywords: fixed-major
Cc: Focuses:

Description

The Test Old Branches workflow is used to dispatch workflow runs for old branches because GitHub does not support the schedule event outside of the default branch.

After [51355], ​has started failing. Since the repository is not checked out in this workflow, the git diff step returns an error. This check can be removed from this workflow.

Change History (3)

#1 @desrosj
5 years ago

  • Owner set to desrosj
  • Resolution → fixed
  • Status new → closed

In 51498:

Build/Test Tools: Remove the check for changes to version-controlled files in the Test Old Branch workflow.

This workflow does not perform a git checkout and is only used to dispatch workflows for old branches, so this check is not needed here.

Fixes #53799.

#2 @desrosj
5 years ago

  • Keywords fixed-major added
  • Milestone 5.9 → 5.8.1
  • Resolution fixed
  • Status closed → reopened

Going to backport this since it was added in 5.8 so that the workflow is consistent in all branches going forward.

#3 @desrosj
5 years ago

  • Resolution → fixed
  • Status reopened → closed

In 51502:

Build/Test Tools: Remove the check for changes to version-controlled files in the Test Old Branch workflow.

This workflow does not perform a git checkout and is only used to dispatch workflows for old branches, so this check is not needed here.

Merges [51498] to the 5.8 branch.
Fixes #53799.

Note: See TracTickets for help on using tickets.