Update SimplePie to version 1.8.0

[jrf]

A new version of SimplePie has just been released.

This version contains a few enhancements and some bug fixes.

The most notable change, however, is that this release contains a forward-compatibility layer for the change to PSR-4 namespaced classes which is targetted for SimplePie 2.0.0.

With some similarity to Requests - the namespaced versions of the classes are in a different base directory (src) from the original versions (library).

As WP currently only includes the files in the library directory, I would like to suggest to continue doing so for now.
This still makes the forward-compatibility layer available as all files in the library directory now create a class alias to their namespaced version.

Once 2.0.0 has been released, the files included in WP, should be switched to the files from the src directory (which is currently in place mostly to allow for Composer autoloading) and should start using the namespaced names for the SimplePie classes.

I'd recommend for this update to be mentioned in a dev-note, so plugins/themes directly using SimplePie can decide for themselves when they want to change to using the namespaced names for SimplePie classes.

Refs:

• ​https://github.com/simplepie/simplepie/releases/tag/1.6.0
• ​https://github.com/simplepie/simplepie/blob/1.6.0/CHANGELOG.md#160---2022-04-21
• ​https://github.com/simplepie/simplepie/compare/1.5.8...1.6.0

I've done a cursory check of the changes and they look sane to me, but would very much like to invite a second opinion and I'd recommend testing this change (more thoroughly than usually done for upgrades like these).

I'd also like to recommend for a few cursory tests to be added to the WP test suite to ensure that both the PSR-0 as well as the PSR-4 class names load correctly when only including the library directory in WP.

I'd recommend for this update to be applied in WP 6.1 early.

Previous: #36669, #51521, #54659

[costdev]

Adding 2nd-opinion and needs-unit-tests per recommendations in the ticket summary.

[chaion07]

Thanks @jrf for reporting this. We reviewed this ticket during a recent bug-scrub session. Based on the feedback received from the team, we feel that this ticket needs unit testing and/ or, patches before anything can be done for this ticket to move closer to a resolution.

Props: @cu121 & @markparnell

[audrasjb]

Hello there, as per today's bug scrub, just wanted to mention that we'll give this ticket a few days before moving in to Future Release, as it is marked as early and as we're just one month away from 6.1 beta 1 :)

[chaion07]

Thanks @jrf for reporting this. We reviewed this ticket during a ​recent bug-scrub session. We are updating the ticket with the following changes:

1. Updating milestone to Future Release considering no significant change has taken place.

Props to @audrasjb

[jrf]

In the mean time SimplePie 1.7.0 has just been released:

• ​https://github.com/simplepie/simplepie/blob/1.7.0/CHANGELOG.md#170---2022-09-30
• ​https://github.com/simplepie/simplepie/releases/tag/1.7.0
• ​https://github.com/simplepie/simplepie/compare/1.6.0...1.7.0

Note: as the codebase has undergone a code style cleanup, the diff is kind of useless.
For a code review of the 1.7.0 release, we'll probably need to review the individual commits (with the exception of the code style one).

---

Based on the discussion in ​this ticket in the SimplePie repo, the intention is to make 1.7.0 an LTS branch which will keep supporting PHP 5.6 for the foreseeable future.

SimplePie 1.8.0 is slated to drop support for PHP < 7.2.

[audrasjb]

As per today's bug scrub: since this ticket is marked for early commit and as it is still waiting for a patch and testing, let's move it to Future Release.

[hellofromTonya]

Moving this into 6.3.

[audrasjb]

No update during the 6.3 early cycle: moving to milestone 6.4.

[Presskopp]

​https://github.com/simplepie/simplepie/releases/tag/1.8.0

[jrf]

@Presskopp Unfortunately upgrading to 1.8.0 is not an option for WordPress as it raises the minimum supported PHP version to 7.2, while WP still supports PHP 5.6.

​https://github.com/simplepie/simplepie/blob/1.8.0/CHANGELOG.md#180---2023-01-20

[Presskopp]

Ah, yes, sorry I didn't think about that. But on the other hand the support for 5.6 could end soon, see https://core.trac.wordpress.org/ticket/57345#comment:111

[jrf]

@Presskopp I hear you, but I'll believe when I see it...

[Presskopp]

Replying to jrf:

@Presskopp I hear you, but I'll believe when I see it...

:-) The hope dies last

​https://make.wordpress.org/core/2023/07/05/dropping-support-for-php-5/ we're getting close @jrf

[hellofromTonya]

I'd recommend for this update to be applied in WP 6.1 early.

6.4 is in the middle of the beta cycle with RC1 fast approaching. It's too late for early tasks. Though it's marked as a blessed task, there's work to be done in reviewing the version and preparing tests

I've done a cursory check of the changes and they look sane to me, but would very much like to invite a second opinion and I'd recommend testing this change (more thoroughly than usually done for upgrades like these).

I'd also like to recommend for a few cursory tests to be added to the WP test suite to ensure that both the PSR-0 as well as the PSR-4 class names load correctly when only including the library directory in WP.

I know this ticket has been kicked down the road release after release. Should it go into Future Release or the next milestone 6.5? Moving it to 6.5 might give it visibility, though it hasn't yet. But in the effort to keep dependencies (near) up-to-date, trying for one more major. Punting to 6.5.

[audrasjb]

It’s a bit late in 6.5 cycle to commit an early ticket, moving to Future release

[desrosj]

Just noting that as of [57985], the minimum required version for WordPress has been updated to 7.2.24. This change will be shipped in WordPress 6.6, but beta is only 1 month away (currently scheduled for 4 June). That may be too soon for adequate testing unless there are enough interested contributors with the bandwidth. But it would be great to get a PR started.

Not going to move this to the 6.6 milestone until there's consensus that everyone is comfortabl with that timeline.

[jrf]

AS WP 6.6 has now been released, I'd recommend for a patch to be created based on SimplePie 1.8.0 ASAP for committal early in the 6.7 release cycle to allow for sufficient testing.

• ​https://github.com/simplepie/simplepie/releases/tag/1.8.0
• ​https://github.com/simplepie/simplepie/blob/master/CHANGELOG.md#180---2023-01-20
• Diff with the version currently shipped with WP Core: ​https://github.com/simplepie/simplepie/compare/1.5.8...1.8.0

Trac ticket: https://core.trac.wordpress.org/ticket/55604

The PR only have one file change, There should be more per ​https://github.com/simplepie/simplepie/compare/1.5.8...1.8.0

@mukeshpanchal27 I've added more files, but since the new version uses PSR-4, @peterwilsoncc suggested including the src folder as well. I'm still figuring out how to do that.

@mukeshpanchal27 just following up on the blocker here. Can you please ping someone who can review or help with this PR?

@faisal-alvi I did some very rough experimenting with dropping the simple pie zip in to the existing folder (ie, moving the library files in to the library directory) and replacing inclusion of files with their new autoloader.

It wasn't super successful as WP_Feed_Cache_Transient is now required to implement SimplePie\Cache\Base which is not the case.

IN short, it loosk like there will be quite a bit of messing around require to upgrade to 1.8.0.