Display date of Site health report creation

[sebastienserre]

Hello,

Site Health is full of great info when, like me you're doing support all the days.

I think the creation date is missing because WordPress user are installing / removing / updating Core, plugins and theme and we need to know what was the date the report has been created.

This Trac ticket and the patch will add this information.

[sebastienserre]

Site health extraction

[sebastienserre]

Site health in tool menu

[sebastienserre]

I wonder if "Generation Date" instead of "Creation date" and "Generated" instead of "creation_date" shouldn't be better

[Clorith]

Interesting thought, I'm not sure a new section is the right approach for this information though, but i do see its value from a support perspective.

What if it instead included something like like "Current server time", and "Current UTC time" under the "Server" section? That would both give you the current time, the server time, allow for comparison if there's some time-related issues, but still provides the information?

I'd also love to see the debug field be populated with an ISO 8601 formatted data, that isn't dependent on the configured date format of the site. (that would be the YYYY-MM-DD formatting, optionally with the current time added as well if that makes sense).

[sebastienserre]

Hello,

Thanks @Clorith for your review and ideas.
I add a new patch Add-Date-56378.patch with your idea.

[sebastienserre]

Hello,
What's missing to move up this ticket ?
May I do something ?

[audrasjb]

The logic of the latter patch looks good to me at a glance.
Let's put together a GitHub pull request to ensure tests are passing (I think we have a few coding standards issues to fix).

[audrasjb]

Add-Date-56378.patch

[audrasjb]

Add-Date-56378.patch - copy from clipboard:

current: 2023-06-15T10:19:31+00:00
utc-time: Thursday, 15-Jun-23 10:19:31 UTC
server-time: 2023-06-15T10:19:29+00:00

https://core.trac.wordpress.org/ticket/56378

[audrasjb]

PR4620 refreshes the patch against trunk and fixes various coding standard issues.

Moving for 6.3 consideration.

[sebastienserre]

OK, so the patch always work, I've tested with the beta test plugin set to update to the nightly release...
NodeJS is insulting me when I try to build WordPress-develop... I will dig in this soon

Comment on line 842 should end with a period.

[robinwpdeveloper]

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/4620

Environment

• OS: macOS 13.2.1 (22D68)
• Web Server: Nginx
• PHP: 7.4.30
• WordPress: 6.3-alpha-55505-src
• Browser: Chrome 114.0.5735.106
• Theme: Twenty Twenty-Three
• Active Plugins:
  • No plugins activated

Actual Results

• ✅ Expected result works as expected with patch.

Additional Notes

• Tools => Site Health => Info => Server displays Current date, Current UTC time, Current Server time

Supplemental Artifacts

Before: ​https://d.pr/i/XlRhFm
After: ​https://d.pr/i/DqYYtM

The label Current date should read Current time, as the value displays date and time as well.

@audrasjb I'm not sure how to improve this PR with @hareesh-pillai suggestion as the branch is on your side :pensive:
If I can help, feel free to ping.

Hey @sebastienserre feel free to add a new patch in the ticket. Then I can port it to my PR so we can run unit test on it :)

[sebastienserre]

Add suggestion made at ​https://github.com/WordPress/wordpress-develop/pull/4620#issuecomment-1593110036

[hrrarya]

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/4620

Environment

• OS: macOS 12.6.7
• Web Server: Nginx
• PHP: 7.4.33
• WordPress: 6.3-alpha-55505-src
• Browser: Brave 1.52.126
• Theme: Twenty Twenty-Three
• Active Plugins: No plugins activated

Actual Results

• ✅ Issue resolved with patch.

Additional Notes

• we got Current time, Current UTC time, Current Server time from Tools->Site Health-> Info-> Server

Supplemental Artifacts

Before: ​https://prnt.sc/tY_st3Ccuh4H
After: ​https://prnt.sc/PO4icw85a5-d

[audrasjb]

In 56056:

Site Health: Add server time debug data.

This changeset adds "Current time, "Current UTC time" and "Current Server time" under the "Server" section of Site Health debug infos. This provides the
current time, the server time, and allow for comparison if there's some time-related issues.

Props sebastienserre, Clorith, audrasjb, kebbet, robinwpdeveloper, hrrarya, mukesh27, hareesh-pillai, costdev.
Fixes #56378.

committed in https://core.trac.wordpress.org/changeset/56056