Make WordPress Core

Opened 23 months ago

Closed 12 months ago

Last modified 12 months ago

#56378 closed enhancement (fixed)

Display date of Site health report creation

Reported by: sebastienserre's profile sebastienserre Owned by: audrasjb's profile audrasjb
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: Site Health Keywords: has-patch has-screenshots needs-testing
Focuses: Cc:

Description

Hello,

Site Health is full of great info when, like me you're doing support all the days.

I think the creation date is missing because WordPress user are installing / removing / updating Core, plugins and theme and we need to know what was the date the report has been created.

This Trac ticket and the patch will add this information.

Attachments (6)

2022-08-15_15-02.jpg (31.2 KB) - added by sebastienserre 23 months ago.
Site health extraction
2022-08-15_15-02_1.jpg (43.7 KB) - added by sebastienserre 23 months ago.
Site health in tool menu
Add_Site_health_creation_Date.patch (917 bytes) - added by sebastienserre 23 months ago.
Add-Date-56378.patch (1.1 KB) - added by sebastienserre 22 months ago.
Capture d’écran 2023-06-15 à 12.20.15.png (90.2 KB) - added by audrasjb 12 months ago.
Add-Date-56378.patch
56378-3.patch (880 bytes) - added by sebastienserre 12 months ago.
Add suggestion made at https://github.com/WordPress/wordpress-develop/pull/4620#issuecomment-1593110036

Download all attachments as: .zip

Change History (30)

@sebastienserre
23 months ago

Site health extraction

@sebastienserre
23 months ago

Site health in tool menu

#1 @sebastienserre
23 months ago

I wonder if "Generation Date" instead of "Creation date" and "Generated" instead of "creation_date" shouldn't be better

#2 @Clorith
22 months ago

Interesting thought, I'm not sure a new section is the right approach for this information though, but i do see its value from a support perspective.

What if it instead included something like like "Current server time", and "Current UTC time" under the "Server" section? That would both give you the current time, the server time, allow for comparison if there's some time-related issues, but still provides the information?

I'd also love to see the debug field be populated with an ISO 8601 formatted data, that isn't dependent on the configured date format of the site. (that would be the YYYY-MM-DD formatting, optionally with the current time added as well if that makes sense).

#3 @sebastienserre
22 months ago

Hello,

Thanks @Clorith for your review and ideas.
I add a new patch Add-Date-56378.patch with your idea.

#4 @desrosj
21 months ago

  • Milestone changed from Awaiting Review to Future Release
  • Version trunk deleted

#5 @sebastienserre
17 months ago

Hello,
What's missing to move up this ticket ?
May I do something ?

This ticket was mentioned in Slack in #core by sebastienserre. View the logs.


12 months ago

#7 @audrasjb
12 months ago

The logic of the latter patch looks good to me at a glance.
Let's put together a GitHub pull request to ensure tests are passing (I think we have a few coding standards issues to fix).

@audrasjb
12 months ago

Add-Date-56378.patch

#8 @audrasjb
12 months ago

  • Keywords has-screenshots added

Add-Date-56378.patch - copy from clipboard:

current: 2023-06-15T10:19:31+00:00
utc-time: Thursday, 15-Jun-23 10:19:31 UTC
server-time: 2023-06-15T10:19:29+00:00

#10 @audrasjb
12 months ago

  • Keywords 2nd-opinion removed
  • Milestone changed from Future Release to 6.3

PR4620 refreshes the patch against trunk and fixes various coding standard issues.

Moving for 6.3 consideration.

#11 @sebastienserre
12 months ago

OK, so the patch always work, I've tested with the beta test plugin set to update to the nightly release...
NodeJS is insulting me when I try to build WordPress-develop... I will dig in this soon

@kebbet commented on PR #4620:


12 months ago
#12

Comment on line 842 should end with a period.

#13 @robinwpdeveloper
12 months ago

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: https://github.com/WordPress/wordpress-develop/pull/4620

Environment

  • OS: macOS 13.2.1 (22D68)
  • Web Server: Nginx
  • PHP: 7.4.30
  • WordPress: 6.3-alpha-55505-src
  • Browser: Chrome 114.0.5735.106
  • Theme: Twenty Twenty-Three
  • Active Plugins:
    • No plugins activated

Actual Results

  • ✅ Expected result works as expected with patch.

Additional Notes

  • Tools => Site Health => Info => Server displays Current date, Current UTC time, Current Server time

Supplemental Artifacts

Before: https://d.pr/i/XlRhFm
After: https://d.pr/i/DqYYtM

@Hareesh Pillai commented on PR #4620:


12 months ago
#14

The label Current date should read Current time, as the value displays date and time as well.

@sebastienserre commented on PR #4620:


12 months ago
#15

@audrasjb I'm not sure how to improve this PR with @hareesh-pillai suggestion as the branch is on your side :pensive:
If I can help, feel free to ping.

@audrasjb commented on PR #4620:


12 months ago
#16

Hey @sebastienserre feel free to add a new patch in the ticket. Then I can port it to my PR so we can run unit test on it :)

#19 @oglekler
12 months ago

  • Keywords needs-testing added

#20 @hrrarya
12 months ago

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: https://github.com/WordPress/wordpress-develop/pull/4620

Environment

  • OS: macOS 12.6.7
  • Web Server: Nginx
  • PHP: 7.4.33
  • WordPress: 6.3-alpha-55505-src
  • Browser: Brave 1.52.126
  • Theme: Twenty Twenty-Three
  • Active Plugins: No plugins activated

Actual Results

  • ✅ Issue resolved with patch.

Additional Notes

  • we got Current time, Current UTC time, Current Server time from Tools->Site Health-> Info-> Server

Supplemental Artifacts

Before: https://prnt.sc/tY_st3Ccuh4H
After: https://prnt.sc/PO4icw85a5-d

This ticket was mentioned in Slack in #core by chaion07. View the logs.


12 months ago

#22 @audrasjb
12 months ago

  • Owner set to audrasjb
  • Resolution set to fixed
  • Status changed from new to closed

In 56056:

Site Health: Add server time debug data.

This changeset adds "Current time, "Current UTC time" and "Current Server time" under the "Server" section of Site Health debug infos. This provides the
current time, the server time, and allow for comparison if there's some time-related issues.

Props sebastienserre, Clorith, audrasjb, kebbet, robinwpdeveloper, hrrarya, mukesh27, hareesh-pillai, costdev.
Fixes #56378.

#24 @himadree12
12 months ago

Last edited 12 months ago by himadree12 (previous) (diff)
Note: See TracTickets for help on using tickets.