Context Navigation

← Previous Ticket
Next Ticket →

#56666 closed defect (bug) (fixed)

Bug/performance: No need to make repeat calls to `get_theme_file_path` in `register_block_style_handle`

Reported by:	aristath	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	6.1
Component:	General	Version:	6.1
Severity:	normal	Keywords:	has-patch add-to-field-guide
Cc:		Focuses:	performance

Description

The register_block_style_handle function runs ~200 times on each page load.
Each time it runs, we call get_theme_file_path and then run it through wp_normalize_path.
get_theme_file_path calls get_stylesheet_directory, which calls get_stylesheet, which calls get_option, and there's a bunch of filters that run on each iteration of that - without ever changing.

We can cache the value and avoid 200 calls on many functions and filters - improving performance.

Change History (5)

This ticket was mentioned in PR #3341 on WordPress/wordpress-develop by aristath.

4 years ago #1

Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/56666

mukeshpanchal27 commented on PR #3341:

4 years ago #2

@aristath Can we add this new cache related code after the if statement line no. 222? Because we required it there, not prior?

https://github.com/WordPress/wordpress-develop/blob/d2fa335b47080abb0c7e2869687906dc32d629f0/src/wp-includes/blocks.php#L185-L189

https://github.com/WordPress/wordpress-develop/blob/d2fa335b47080abb0c7e2869687906dc32d629f0/src/wp-includes/blocks.php#L222

#3 @SergeyBiryukov
4 years ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

In 54327:

Blocks: Remove extra get_theme_file_path() calls in register_block_style_handle().

The register_block_style_handle() function runs ~200 times on each page load. Each time it runs, we call get_theme_file_path() and then run it through wp_normalize_path().

get_theme_file_path() calls a few other functions: get_stylesheet_directory(), get_stylesheet(), get_option(), and there's a bunch of filters that run on each iteration of that, without ever changing.

By caching the value in a static variable, we can avoid ~200 calls on many functions and filters, improving performance.

Follow-up to [53091], [54290], [54291], [54309].

Props aristath, mukesh27.
Fixes #56666.

SergeyBiryukov commented on PR #3341:

4 years ago #4

Thanks for the PR! Merged in r54327.

#5 @milana_cap
4 years ago

Keywords add-to-field-guide added

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#56666 closed defect (bug) (fixed)

Bug/performance: No need to make repeat calls to `get_theme_file_path` in `register_block_style_handle`

Description

Change History (5)

This ticket was mentioned in ​PR #3341 on ​WordPress/wordpress-develop by ​aristath. 4 years ago #1

​mukeshpanchal27 commented on ​PR #3341: 4 years ago #2

#3 @SergeyBiryukov 4 years ago

​SergeyBiryukov commented on ​PR #3341: 4 years ago #4

#5 @milana_cap 4 years ago