Make WordPress Core

Opened 16 months ago

Closed 16 months ago

Last modified 16 months ago

#57029 closed defect (bug) (invalid)

Insecure links needs to be replaced with the secure ones.

Reported by: krunal265's profile krunal265 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: has-patch
Focuses: docs Cc:

Description

I came across the file where the insecure link was added even if the secure link is active on the web.

Attachments (1)

57029.patch (532 bytes) - added by krunal265 16 months ago.
patch added.

Download all attachments as: .zip

Change History (7)

@krunal265
16 months ago

patch added.

#1 @krunal265
16 months ago

  • Keywords has-patch added

#2 @rudlinkon
16 months ago

Related to #57028

#3 @dd32
16 months ago

  • Component changed from General to External Libraries
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

SimplePie is an external library, and this should be reported upstream directly to them:

https://github.com/simplepie/simplepie

I'm marking this as invalid, noting that if it's changed upstream in the project it'll be merged to WordPress in it's next release.

#4 @dd32
16 months ago

Also, When submitting patches, please do a more complete review rather than selecting a singular instance.

There's numerous other http:// strings in the SimplePie codebase, including one on the very next line after 57029.patch.

#5 @audrasjb
16 months ago

Also, please add similar patches in the previous similar ticket (#57017) opened by your colleague, to avoid too much duplicate tickets about the same change.

#6 @krunal265
16 months ago

Hello @audrasjb,

I have attached the patch file as per your suggestion.
Thanks.

Note: See TracTickets for help on using tickets.