Coding Standards: Use strict comparison in wp-admin/includes/nav-menu.php

[jenilk]

Coding Standards: Use strict comparison in wp-admin/includes/nav-menu.php

[johnbillion]

Thanks for the patch @jenilk! Are all of these variables guaranteed to be of the same type? For example data coming in via $_POST may be a string, etc.

[jenilk]

Replying to johnbillion:

Thanks for the patch @jenilk! Are all of these variables guaranteed to be of the same type? For example data coming in via $_POST may be a string, etc.

@johnbillion - I made changes to the 4 places, and out of them, there are 2 places where the data is coming as $_POST for comparison. We can not be guaranteed of it will be of the same type(FYI we don't have declared variable with datatype specification).

[SergeyBiryukov]

Thanks for the patch!

In my testing, $_item_object_data['menu-item-db-id'] and $_POST['menu-item-db-id'][ $_key ] can be a string and need a type cast to int for correct comparison. The other two changes look good as is to me.

[SergeyBiryukov]

In 55593:

Coding Standards: Use strict comparison in wp-admin/includes/nav-menu.php.

Follow-up to [14248], [15008], [37748].

Props jenilk, johnbillion.
Fixes #57318.

[dd32]

In 55596:

Coding Standards: Use the correct variable.

Follow-up to [55593].

See #57318.