Context Navigation

← Previous Ticket
Next Ticket →

#57318 closed defect (bug) (fixed)

Coding Standards: Use strict comparison in wp-admin/includes/nav-menu.php

Reported by:	jenilk	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	6.3
Component:	Menus	Version:
Severity:	normal	Keywords:	has-patch needs-test-info
Cc:		Focuses:	coding-standards

Description

Attachments (1)

57318.patch (1.7 KB ) - added by jenilk 4 years ago.

Download all attachments as: .zip

Change History (7)

@jenilk
4 years ago

Attachment 57318.patch added

#1 follow-up: ↓ 2 @johnbillion
4 years ago

Keywords has-patch needs-testing-info added
Severity major → normal

Thanks for the patch @jenilk! Are all of these variables guaranteed to be of the same type? For example data coming in via $_POST may be a string, etc.

#2 in reply to: ↑ 1 @jenilk
4 years ago

Replying to johnbillion:

Thanks for the patch @jenilk! Are all of these variables guaranteed to be of the same type? For example data coming in via $_POST may be a string, etc.

@johnbillion - I made changes to the 4 places, and out of them, there are 2 places where the data is coming as $_POST for comparison. We can not be guaranteed of it will be of the same type(FYI we don't have declared variable with datatype specification).

#3 @SergeyBiryukov
3 years ago

Milestone Awaiting Review → 6.3

Thanks for the patch!

In my testing, $_item_object_data['menu-item-db-id'] and $_POST['menu-item-db-id'][ $_key ] can be a string and need a type cast to int for correct comparison. The other two changes look good as is to me.