Site Health: Improve display of constants in debug data

[ramon fincken]

This is a follow up on #55741.

where we need to have just a single function to be called which determines the environment type.

As wp-admin/includes/class-wp-debug-data.php is already using:

$environment_type       = wp_get_environment_type();

and later on:
this happens

		// Check WP_ENVIRONMENT_TYPE.
		if ( defined( 'WP_ENVIRONMENT_TYPE' ) && WP_ENVIRONMENT_TYPE ) {
			$wp_environment_type = WP_ENVIRONMENT_TYPE;
		} else {
			$wp_environment_type = __( 'Undefined' );
		}

so this is not the same as what happens at wp_get_environment_type();

So this ticket is where we remove that lines of code.

[ramon fincken]

patch.58484.20230608.1.diff

[ramon fincken]

a small update on this, checked with @SergeyBiryukov

this code is accurate meaning it is shown in the tools -> constants.

I will just show the PHP constant which does not have a need to call wp_get_environment_type()

However ... if you have defined WP_ENVIRONMENT_TYPE and it is empty this code will show "Undefined" while it is actually defined indeed.

[ramon fincken]

creating a new patch for this

[ramon fincken]

patch.58484.20230608.2.diff

[ramon fincken]

patch.58484.20230608.3.diff

[ramon fincken]

Added function

private static function get_define_info( $constant_name ) {

[ramon fincken]

Updated patch for latest Core version.

[ramon fincken]

patch.58484.20231019.4.diff

[ramon fincken]

patch.58484.20231019.5.diff

[ramon fincken]

patch.58484.20231019.6.diff

[ramon fincken]

patch.58484.20231019.7.diff

Trac ticket: https://core.trac.wordpress.org/ticket/58484

PR to enhance the tools section to show the actual result of defines.

[ramon fincken]

The github PR is the latest. Checked with @ocean90 .

So .. we have the changed code to reflect the actual values.
Also we needed a change for the debug values as you can define an empty string or for instance a NULL/null. Therefore we needed to rewrite the isset to key_exists.

Also some translator instructions were added.

We choose to use multi if instead of match/switch because it is more human readable.

[swissspidy]

@SergeyBiryukov Is this on your radar still for 6.5? Looks like a punt candidate given the lack of activity.

[swissspidy]

Looks more like an enhancement to me, so punting.

[ramon fincken]

Bummer it did not make it in 6.5

[oglekler]

I think this new function should also handle case for WP_DEBUG_LOG and possibly two conditions (for true and false) can be replaced with one is_bool();

Btw, we have 2 weeks until Beta 1 and this is clearly an enhancement.

[nhrrob]

We have reviewed this ticket in today's bug scrub.
@SergeyBiryukov do you think it can land in 6.6?

What else is needed to move it forward?

Thank you.

[oglekler]

We have 2 days before Beta 1 and no concrete decision, so, I am moving this ticket to the next milestone for further work.

[ramon fincken]

Can we try to get it into 6.6.1 ?

[SergeyBiryukov]

Related: #58265

[stoyangeorgiev]

This one was discussed at a few bug-scrubs and setting the milestone to a Future-Release is something we can do with 6.7 right around the corner. It can be moved to 6.8 when the time is right!

Cheers!