Make WordPress Core

Opened 10 months ago

Closed 3 months ago

#58784 closed enhancement (wontfix)

Change "Edit more details" to "Edit" in the attachment details

Reported by: nekojonez's profile NekoJonez Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.0
Component: Media Keywords: has-patch close
Focuses: ui, administration, ui-copy Cc:

Description

Today, I was messing around with the newest beta of WordPress 6.3 and since the image editor moved underneath a button on the "Edit more details" link... I'd change the text.

My suggestion is to change it to "Edit attachment and details" so it's a bit more clear to end users.

(Creating a PR on GitHub for it too)

Attachments (1)

Opera Momentopname_2023-07-11_184101_betatest.local.png (36.3 KB) - added by NekoJonez 10 months ago.

Download all attachments as: .zip

Change History (28)

This ticket was mentioned in PR #4830 on WordPress/wordpress-develop by @NekoJonez.


10 months ago
#1

  • Keywords has-patch added

In this PR, I change a text line since in WP 6.3 the media editor moved and now it's not too clear for end users that it's underneath one button. So, I suggest changing that button to another bit of text so end users can find it again :)

Trac ticket: #58784

This ticket was mentioned in Slack in #core by nekojonez. View the logs.


10 months ago

This ticket was mentioned in Slack in #core by nekojonez. View the logs.


10 months ago

This ticket was mentioned in Slack in #core by nekojonez. View the logs.


10 months ago

#5 @SergeyBiryukov
10 months ago

  • Milestone changed from Awaiting Review to 6.4

#6 @sabernhardt
10 months ago

  • Focuses ui-copy added
  • Version changed from trunk to 4.0

#7 @jamieblomerus
9 months ago

I don't really think we need to change it, as it is already clear enough. Changing it to the proposed "Edit attachment and details" does not really make it any clearer than what it already is.

But that is just my own opinion. I may be wrong.

Last edited 9 months ago by jamieblomerus (previous) (diff)

#8 @dhruvishah2203
9 months ago

I think we can change it from edit more details to edit attachment details so users can understand which data can modify.

This ticket was mentioned in Slack in #core-media by antpb. View the logs.


9 months ago

#10 follow-up: @antpb
9 months ago

  • Keywords reporter-feedback added

Hi @NekoJonez ! This ticket was discussed in a recent Media component meeting and we are unclear on what raised this issue. The text and location has been there for a while and was not introduced in 6.3.

Just trying to understand more what this text change fixes in the experience of editing attachment details. We are generally in agreement in the meeting that the current text is clear in the context of the frame and are curious if there is a case we're not considering.

Thanks!

#11 in reply to: ↑ 10 @NekoJonez
9 months ago

Replying to antpb:

Hi @NekoJonez ! This ticket was discussed in a recent Media component meeting and we are unclear on what raised this issue. The text and location has been there for a while and was not introduced in 6.3.

Just trying to understand more what this text change fixes in the experience of editing attachment details. We are generally in agreement in the meeting that the current text is clear in the context of the frame and are curious if there is a case we're not considering.

Thanks!

In my honest opinion... Since, it's more then just editing the details (since the edit media button is on the screen you go to)... it should say more than just "edit details". Since, you can also crop & rotate that way. The "edit" is fine, but the "details" isn't. Since, I have seen people click on there to just edit details like metadata and such. But, when they want to crop the image, they don't find the way and just upload a cropped version whilst they can do it in WP.

This ticket was mentioned in Slack in #polyglots by nekojonez. View the logs.


9 months ago

#13 @oglekler
8 months ago

This Attachment page is confusing, and you need to search for this button to edit the Attachment to realize that there is difference with previous UI abilities, but I wonder if Edit attachment and attachment details is too lengthy and Edit attachment can be better. Still, this button needs to be found, and possibly this is also an issue we can address. But otherwise it will be better than now, because there are more details (possibly they can be added by plugins, but in most cases you will not find mode detail to edit).

This ticket was mentioned in Slack in #core-media by antpb. View the logs.


8 months ago

#15 @oglekler
7 months ago

How about an Advanced edit? We have like 8 days before Beta 1, so, in order to see this change in 6.4, we need some decision.

#16 @oglekler
7 months ago

@fierevere and @tobifjellner, can you please look at this ticket?

#17 @tobifjellner
7 months ago

I like "Advanced edit" :)

This ticket was mentioned in PR #5288 on WordPress/wordpress-develop by @oglekler.


7 months ago
#18

Change of phrase to make clear what should be expected.

Trac ticket: https://core.trac.wordpress.org/ticket/58784

This ticket was mentioned in Slack in #core by oglekler. View the logs.


7 months ago

#20 @hellofromTonya
7 months ago

Discussed during today's scrub.

Seems there's not yet consensus on if it should be changed or what it should be changed to for clarity. In other words, this ticket needs more time for feedback, consideration, and consensus before it's ready to commit.

Also noting, the text has been in Core since around WP 3, i.e. a long long time.

6.4 Triagers, the proposed change is text only. Thus, it can stay in the milestone up to string freeze.

#21 @sabernhardt
7 months ago

The text may have been in Core before 4.0, but it was added to media-template.php in [29204] (still very old).

@NekoJonez commented on PR #4830:


7 months ago
#22

I'm going to close this PR, since due to me being extremely busy & a new better PR being created.
https://github.com/WordPress/wordpress-develop/pull/5288

@NekoJonez commented on PR #5288:


7 months ago
#23

Thanks! I wanted to update my PR but I got way to busy at my job... But this is also an amazing solution.
I closed my old PR in favor of this one :)

#24 @oglekler
7 months ago

  • Keywords reporter-feedback removed
  • Milestone changed from 6.4 to 6.5

Because some folk has doubts including the fact that this text is already so long time in the core, we need everyone to agree with change because it will happen. And because this ticket is treated as an enhancement, it is going to 6.5 for further consideration. Thank you everyone. I hope we will tackle this in the beginning of next release cycle, not waiting until the last moment.

This ticket was mentioned in Slack in #core-media by joedolson. View the logs.


6 months ago

#26 @joedolson
6 months ago

  • Keywords close added

Per discussion in Slack, the media team thinks that the cost of doing this change is too great to balance the minor benefit from a possibly clearer link text. This isn't necessarily that the text change wouldn't be better, but it's not enough better to justify the amount of time translators would spend, plus the labor for outdated tutorials, screenshots, and user instructions that might reference this link.

Recommending for close, but happy to hear continued arguments.

#27 @joedolson
3 months ago

  • Milestone 6.5 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Per the above comment, and lacking any further comments, I'm closing this issue. If anybody would still like to press for it, feel free to continue the conversation or reopen.

Note: See TracTickets for help on using tickets.