Opened 16 months ago
Closed 16 months ago
#58889 closed defect (bug) (fixed)
Fix template parts mode check in site-editor.php
Reported by: | Mamaduka | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 6.3 | Priority: | normal |
Severity: | normal | Version: | 6.3 |
Component: | Editor | Keywords: | has-testing-info has-patch commit dev-reviewed fixed-major |
Focuses: | Cc: |
Description
Recently Site Editor client-side routing started using only the path
query argument for loading non-editor views.
The router removes the postType
query argument, which causes an error message to be displayed when you reload the template parts list page.
- Activate a theme that enables block-based template parts - https://github.com/Mamaduka/block-fragments or https://github.com/WordPress/gutenberg/tree/trunk/test/gutenberg-test-themes/emptyhybrid.
- Visit the new Appearance > Template Parts menu.
- Reload the page.
- Notice that "The theme you are currently using is not compatible with the Site Editor." message is displayed.
Change History (12)
This ticket was mentioned in PR #4893 on WordPress/wordpress-develop by @Mamaduka.
16 months ago
#1
- Keywords has-patch added
@isabel_brison commented on PR #4893:
16 months ago
#2
Hey @Mamaduka is this PR meant for WP 6.3?
@Mamaduka commented on PR #4893:
16 months ago
#3
@tellthemachines, I think we should land this in 6.3; otherwise, we'll have annoying regression for hybrid themes.
#5
@
16 months ago
- Keywords commit added
PR4893 seems ready for commit
.
Also approving this for backport to branch 6.3.
#9
@
16 months ago
- Owner set to audrasjb
- Resolution set to fixed
- Status changed from new to closed
In 56302:
@audrasjb commented on PR #4893:
16 months ago
#10
Committed in https://core.trac.wordpress.org/ticket/58889
Trac ticket: https://core.trac.wordpress.org/ticket/58889