Context Navigation

← Previous Ticket
Next Ticket →

#58889 closed defect (bug) (fixed)

Fix template parts mode check in site-editor.php

Reported by:	Mamaduka	Owned by:	audrasjb
Priority:	normal	Milestone:	6.3
Component:	Editor	Version:	6.3
Severity:	normal	Keywords:	has-test-info has-patch commit dev-reviewed fixed-major
Cc:		Focuses:

Description

Recently Site Editor client-side routing started using only the path query argument for loading non-editor views.

The router removes the postType query argument, which causes an error message to be displayed when you reload the template parts list page.

Activate a theme that enables block-based template parts - https://github.com/Mamaduka/block-fragments or https://github.com/WordPress/gutenberg/tree/trunk/test/gutenberg-test-themes/emptyhybrid.
Visit the new Appearance > Template Parts menu.
Reload the page.
Notice that "The theme you are currently using is not compatible with the Site Editor." message is displayed.

Change History (13)

This ticket was mentioned in PR #4893 on WordPress/wordpress-develop by @Mamaduka.

3 years ago #1

Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/58889

@isabel_brison commented on PR #4893:

3 years ago #2

Hey @Mamaduka is this PR meant for WP 6.3?

@Mamaduka commented on PR #4893:

3 years ago #3

@tellthemachines, I think we should land this in 6.3; otherwise, we'll have annoying regression for hybrid themes.

#4 @ramonopoly
3 years ago

Milestone Awaiting Review → 6.3
Version → trunk

#5 @audrasjb
3 years ago

Keywords commit added

PR4893 seems ready for commit.
Also approving this for backport to branch 6.3.

#6 @audrasjb
3 years ago

Keywords dev-reviewed added

#7 @audrasjb
3 years ago

@Mamaduka @ramonopoly do you confirm that PR is ready to ship in RC2?

#8 @Mamaduka
3 years ago

Yes, it should be good to shop in RC2. It just needs a commit and backport.

#9 @audrasjb
3 years ago

Owner set to audrasjb
Resolution → fixed
Status new → closed

In 56302:

Editor: Fix conditionals in Template Editing Mode.

Previously, Site Editor client-side routing started using only the path query argument for loading non-editor views. The router removed the postType query
argument, which caused an error message to be displayed when the template parts list page was reloaded.

This changeset fixes the issue as it was affecting hybrid themes.

Props Mamaduka, isabel_brison, ramonopoly.
Fixes #58889.

@audrasjb commented on PR #4893:

3 years ago #10

Committed in https://core.trac.wordpress.org/ticket/58889

#11 @audrasjb
3 years ago

Keywords fixed-major added
Resolution fixed
Status closed → reopened

#12 @audrasjb
3 years ago

Resolution → fixed
Status reopened → closed

In 56303:

Editor: Fix conditionals in Template Editing Mode.

This changeset fixes the issue as it was affecting hybrid themes.

Props Mamaduka, isabel_brison, ramonopoly.
Reviewed by isabel_brison, audrasjb.
Merges [56302] to the 6.3 branch.
Fixes #58889.

#13 @wordpressdotorg
14 months ago

Keywords has-test-info added; has-testing-info removed

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#58889 closed defect (bug) (fixed)

Fix template parts mode check in site-editor.php

Description

Change History (13)

This ticket was mentioned in ​PR #4893 on ​WordPress/wordpress-develop by ​@Mamaduka. 3 years ago #1

​@isabel_brison commented on ​PR #4893: 3 years ago #2

​@Mamaduka commented on ​PR #4893: 3 years ago #3

#4 @ramonopoly 3 years ago

#5 @audrasjb 3 years ago

#6 @audrasjb 3 years ago

#7 @audrasjb 3 years ago

#8 @Mamaduka 3 years ago

#9 @audrasjb 3 years ago

​@audrasjb commented on ​PR #4893: 3 years ago #10

#11 @audrasjb 3 years ago

#12 @audrasjb 3 years ago

#13 @wordpressdotorg 14 months ago