WordPress.org
Get WordPress

Make WordPress Core

Opened 2 months ago

Closed 4 weeks ago

Last modified 4 weeks ago

#58890 closed defect (bug) (fixed)

Docs: Parameter comment is missing for __get function

Reported by: armondal's profile armondal Owned by: audrasjb's profile audrasjb
Milestone: 6.4 Priority: normal
Severity: normal Version: 4.4
Component: Comments Keywords: has-patch
Focuses: docs Cc:

Description (last modified by SergeyBiryukov)

In class-wp-comment.php __get() function inline document does not mention a comment of @param $name on line 371
$name @param should have a comment mentioned

Change History (8)

This ticket was mentioned in ​PR #4894 on ​WordPress/wordpress-develop by ​@armondal.
2 months ago #1

  • Keywords has-patch added

This Pull Request is for code review only. Please keep all other discussions in the Trac ticket. Do not merge this Pull Request. See ​GitHub Pull Requests for Code Review in the Core Handbook for more details.

#2 @audrasjb
2 months ago

  • Component changed from General to Comments
  • Focuses docs added
  • Milestone changed from Awaiting Review to 6.4
  • Version changed from 6.2.2 to 4.4

#3 @audrasjb
2 months ago

  • Keywords commit added
  • Owner set to audrasjb
  • Status changed from new to accepted

​@hztyfoon commented on ​PR #4894:
6 weeks ago #4

Thanks @Armondal for the PR. It looks good to me.
But, I just added a review suggesting a minor change. can you check?

#5 @SergeyBiryukov
6 weeks ago

  • Description modified (diff)

#6 @audrasjb
4 weeks ago

  • Keywords commit removed

#7 @audrasjb
4 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 56433:

Docs: Add missing @param description in WP_Comment class.

Props armondal, hztyfoon, SergeyBiryukov.
Fixes #58890.
See #58833.

Note: See TracTickets for help on using tickets.