Make WordPress Core

Opened 10 months ago

Closed 9 months ago

Last modified 9 months ago

#59388 closed defect (bug) (fixed)

Add `sync patterns` into docs where reusable block(s) are mentioned

Reported by: oglekler's profile oglekler Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.4 Priority: normal
Severity: normal Version: 6.3
Component: Editor Keywords: good-first-bugs has-patch has-copy-review commit dev-reviewed
Focuses: docs Cc:

Description (last modified by hellofromTonya)

During 6.3, reusable blocks were renamed to synced patterns:

WordPress 6.3 renamed Reusable Blocks to Patterns. A synced pattern will behave in exactly the same way as a reusable block.

It looks like we need to have both names alongside in the code docs because we have reusable and block in many places in code and file naming, and it is unnecessary to rename them all, but need to make clear that they are the same thing now.

Change History (23)

#1 @mukesh27
10 months ago

  • Keywords needs-patch good-first-bugs added

#2 @oglekler
10 months ago

  • Milestone changed from Awaiting Review to 6.4

This ticket was mentioned in PR #5286 on WordPress/wordpress-develop by benjaminknox.


10 months ago
#3

  • Keywords has-patch has-unit-tests added; needs-patch removed

This adds comments in the docs that patterns and reusable blocks are the same, that patterns is new since 6.3.0.

Trac ticket: https://core.trac.wordpress.org/ticket/59388

#4 @oglekler
10 months ago

  • Keywords needs-copy-review added; has-unit-tests removed

This ticket was mentioned in Slack in #core by nicolefurlan. View the logs.


10 months ago

This ticket was mentioned in Slack in #core-docs by nicolefurlan. View the logs.


10 months ago

#7 @nicolefurlan
10 months ago

This ticket was discussed in today's bug scrub.

The About page copy review should happen first. Then those changes can be used in the code doc changes. Then the PR can be updated and Core contributors or committers can review those changes.

I've dropped this ticket into #core-docs so that we can get some eyes on it.

Props to @hellofromTonya :)

This ticket was mentioned in Slack in #core by oglekler. View the logs.


9 months ago

#9 @hellofromTonya
9 months ago

  • Keywords has-copy-review commit added; needs-copy-review removed

The user facing copy has been reviewed. Marking this ticket for commit.

Note: The @since notes need review, which the committer can do.

@benjaminknox commented on PR #5286:


9 months ago
#10

If we had time, I would make some copy changes for clarity in line 71 of about.php, but this is not the time. So, officially, LGTM

@marybaum What changes would you make? I don't mind opening it in another PR if you want

@marybaum commented on PR #5286:


9 months ago
#11

Two things:

  1. I would change the phrase 'previously referred to as reusable blocks' to 'formerly reusable blocks' or 'formerly called reusable blocks'
  1. I would change this —

'WordPress 6.3 brings your content, templates, and patterns together in the Site Editor for the first time. Add pages, browse style variations, create synced patterns (previously referred to as “reusable blocks”), and enjoy fine-tuned control over your navigation menus. No more time wasted switching across different site areas—now you can focus on what matters most. Creation to completion, all in one place.' )

to this —

'For the first time ever, WordPress pulls all your tools together. Because now your content, templates, and patterns live in the Site Editor, at your fingertips, ready to help you add pages, consider style variations, build synced patterns (what you used to call 'reusable blocks')' and fine-tune your menus. Starting right now, never spend another second switching from one part of your site to another. Instead, focus on what matters most: concept to complete, in one fluid process, in one convenient place.'

Nothing like pumping extra drama into copy so people can see themselves as the star of the show! Also, we don't need to say 'navigation menus'—one word implies the other. Use as much or as little of this as you like!

#12 @hellofromTonya
9 months ago

  • Description modified (diff)

#13 @hellofromTonya
9 months ago

  • Keywords changes-requested added; commit removed

Changes requested in the patch. Also noting the changes are for code docs only.

@benjaminknox commented on PR #5286:


9 months ago
#14

I would change the phrase 'previously referred to as reusable blocks' to 'formerly reusable blocks' or 'formerly called reusable blocks'

@marybaum I took your suggestion and updated the comments through the PR to read 'formerly called reusable blocks'

@hellofromtonya How does this look?

#15 @rajinsharwar
9 months ago

  • Keywords commit added

I guess this looks good and could be committed before the RC3 (As it's already postponed)

#16 @SergeyBiryukov
9 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#17 @SergeyBiryukov
9 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 57032:

Docs: Update some reusable block references to synced patterns.

In WordPress 6.3, Reusable Blocks were renamed to Patterns. A synced pattern will behave in exactly the same way as a reusable block.

This commit updates some references in DocBlocks and inline comments to use the new name.

Follow-up to [56030].

Props benjaminknox, oglekler, hellofromTonya, marybaum, nicolefurlan.
Fixes #59388.

@SergeyBiryukov commented on PR #5286:


9 months ago
#18

Thanks for the PR! I think we can keep the "(formerly called reusable blocks)" wording in some top-level DocBlocks, but inline comments and unit tests can just use the new name directly.

Merged in r57032 with some adjustments to avoid redundancy.

#19 @SergeyBiryukov
9 months ago

  • Keywords dev-feedback added; changes-requested removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backporting to the 6.4 branch after a second committer's review.

#20 @SergeyBiryukov
9 months ago

In 57033:

Coding Standards: Remove extra space in a comment in WP_REST_Blocks_Controller.

This fixes a WPCS error: Whitespace found at end of line.

Follow-up to [57032].

Props hellofromTonya.
See #59388.

#21 @hellofromTonya
9 months ago

  • Keywords dev-reviewed added; dev-feedback removed

[57032] and [57033] are okay for backport to 6.3 and 6.4 branches.

#22 @SergeyBiryukov
9 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 57040:

Docs: Update some reusable block references to synced patterns.

In WordPress 6.3, Reusable Blocks were renamed to Patterns. A synced pattern will behave in exactly the same way as a reusable block.

This commit updates some references in DocBlocks and inline comments to use the new name.

Follow-up to [56030].

Reviewed by hellofromTonya.
Merges [57032] and [57033] to the 6.4 branch.

Props benjaminknox, oglekler, hellofromTonya, marybaum, nicolefurlan.
Fixes #59388.

#23 @SergeyBiryukov
9 months ago

In 57041:

Docs: Update some reusable block references to synced patterns.

In WordPress 6.3, Reusable Blocks were renamed to Patterns. A synced pattern will behave in exactly the same way as a reusable block.

This commit updates some references in DocBlocks and inline comments to use the new name.

Follow-up to [56030].

Reviewed by hellofromTonya.
Merges [57032] and [57033] to the 6.3 branch.

Props benjaminknox, oglekler, hellofromTonya, marybaum, nicolefurlan.
Fixes #59388.

Note: See TracTickets for help on using tickets.