Make WordPress Core

Opened 8 months ago

Last modified 7 months ago

#59458 new defect (bug)

Duplicate PHP version in PHPUnit job names on GitHub Actions

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by:
Milestone: Future Release Priority: low
Severity: trivial Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:

Description

  1. Go to Commits page.
  2. Click on any of the GitHub Actions result icons (a green check mark or a red cross mark).
  3. Note the duplicate PHP version in the job names, e.g.:
    PHPUnit Tests / PHP 7.0 / PHP 7.0 / MariaDB 10.11
    PHPUnit Tests / PHP 7.0 / PHP 7.0 / MariaDB 10.11 multisite
    PHPUnit Tests / PHP 7.0 / PHP 7.0 / MariaDB 10.4
    PHPUnit Tests / PHP 7.0 / PHP 7.0 / MariaDB 10.4 multisite
    PHPUnit Tests / PHP 7.0 / PHP 7.0 / MariaDB 10.6
    PHPUnit Tests / PHP 7.0 / PHP 7.0 / MariaDB 10.6 multisite
    ...
    

The same is displayed in GitHub Actions checks on individual PRs.

Appears to be related to [56439].

Attachments (3)

59458.diff (981 bytes) - added by SergeyBiryukov 8 months ago.
59458.PNG (222.5 KB) - added by SergeyBiryukov 8 months ago.
workflow-view.png (139.1 KB) - added by desrosj 8 months ago.

Download all attachments as: .zip

Change History (10)

#1 @SergeyBiryukov
8 months ago

  • Keywords has-patch needs-testing added

@SergeyBiryukov
8 months ago

#2 follow-up: @desrosj
8 months ago

This is an annoying inconsistency with how GitHub Actions handles callable workflows.

When looking at a single workflow view, the only way to get the jobs to combine into a collapsible group is if the start of the name of the job within the called workflow matches the end of the job name in the calling one.

It displays nicely on the individual workflow view, but not so much in the PR or commit views.

I've passed this along to GitHub, but haven't heard back yet. We could experiment a bit more to try and find a way around this, but I couldn't find a way. @johnbillion has also toyed around with this a bit, and arrived at the same approach.

#3 in reply to: ↑ 2 @SergeyBiryukov
8 months ago

  • Keywords has-patch needs-testing removed

Replying to desrosj:

When looking at a single workflow view, the only way to get the jobs to combine into a collapsible group is if the start of the name of the job within the called workflow matches the end of the job name in the calling one.

Ah, thanks for that context! The current patch won't work as expected then :)

#4 @desrosj
8 months ago

It would fix the issue on the PR and commit screens, but then on the individual workflow pages, there would just be one massive list of jobs.

This ticket was mentioned in Slack in #core by marybaum. View the logs.


7 months ago

#6 @marybaum
7 months ago

I think we will leave this to yall who are conversant with these committer-type things.

#7 @SergeyBiryukov
7 months ago

  • Milestone changed from 6.4 to Future Release
Note: See TracTickets for help on using tickets.