Make WordPress Core

Opened 5 months ago

Closed 4 months ago

Last modified 4 months ago

#59513 closed defect (bug) (fixed)

The image lightbox feature has display problems in multiple bundled themes

Reported by: poena's profile poena Owned by:
Milestone: 6.4 Priority: normal
Severity: normal Version: 6.4
Component: Bundled Theme Keywords: gutenberg-merge
Focuses: Cc:

Description

The image lightbox displays incorrectly in some classic bundled themes.
It seems the lightbox button is inheriting the theme's button style.

I recommend continued testing in all classic bundled themes.

Testing instructions

Install WordPress trunk (At the time of writing this, that would be the 6.4 beta 1)
Activate a classic theme.
Create a new post or page and add an image block. Select an image.
In the block settings sidebar, enable the option "Expand on Click".

  • Confirm that the image shows, both in the content and when the lightbox is opened.
  • Confirm that the close button is visible and the button text readable.

Twenty Twenty-One

Image blocks with the lightbox featured enabled show as a dark grey area.
The image only shows when you hover over it.

Twenty Twenty

No issues found

Twenty Nineteen

The image shows by default, but is black when you hover over it.
Opinion: when the lightbox is opened, the close button is not broken but may need some styling to match the theme.

Twenty Seventeen

The image shows by default, but is grey when you hover over it.
Opinion: when the lightbox is opened, the close button is not broken but may need some styling to match the theme.

Twenty Sixteen

The image shows by default, but is blue when you hover over it.
When the lightbox is opened, there is a color contrast issue because the text (the X symbol) in the button is too dark against the blue background.

Twenty Twelve

The image shows by default, but is white when you hover over it.

Change History (9)

#1 @poena
5 months ago

  • Milestone changed from Awaiting Review to 6.4

#2 @poena
5 months ago

After posting the ticket I found that this was already reported by @wildworks in the Gutenberg GitHub repository 54940
Let's hold off working on this until we are sure where it should be fixed.

#3 @nicolefurlan
5 months ago

Sounds good @poena – do we think this will still get completed in the 6.4 release cycle? I'm wondering if we should move it to Future Release.

#4 @poena
5 months ago

To my knowledge the lightbox feature is still "blessed" by the 6.4 release leads. And including it in 6.4 while being broken for classic themes seems like a very bad idea, to me. So I expect it to get fixed, or the whole feature to be postponed.

This ticket was mentioned in Slack in #core by oglekler. View the logs.


4 months ago

#6 @oglekler
4 months ago

  • Keywords gutenberg-merge added

This looks like it should be addressed on the Gutenberg side, so, I am marking this as gutenberg-merge.

This ticket was mentioned in Slack in #core by oglekler. View the logs.


4 months ago

#8 @oglekler
4 months ago

  • Resolution set to fixed
  • Status changed from new to closed

It looks like the issue was fixed upstream, so, after the discussion in the Core channel, I am closing this ticket.

#9 @hellofromTonya
4 months ago

The fix was included in today's npm package updates, which will ship in RC1.

Note: See TracTickets for help on using tickets.