Make WordPress Core

Opened 4 months ago

Closed 2 weeks ago

#59657 closed task (blessed) (fixed)

Update `caniuse` data for 6.5

Reported by: desrosj's profile desrosj Owned by:
Milestone: 6.5 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

This ticket is for tracking updates to the caniuse data and documenting resulting changes throughout the 6.5 cycle.

Previously:

Change History (9)

This ticket was mentioned in PR #5939 on WordPress/wordpress-develop by @desrosj.


4 weeks ago
#1

  • Keywords has-patch added

#2 @desrosj
4 weeks ago

I attached a PR that accomplishes this. It seems that we're just constantly adding and removing the same properties release to release:

  • -webkit-min-device-pixel-ratio
  • -o-tab-size
  • -webkit-clip-path.

This seems to have been happening since 6.2 in [55139], [55150], [56279], [56948] and [56956]. I don't love that we're just churning code back and forth even in built files.

Looking at -webkit-min-device-pixel-ratio, I'm not sure why this is being added/removed. It looks like this is a currently supported property in Safari.

-webkit-clip-path also appears to not be required in versions with enough usage to be added back.

For -o-tab-size, this looks to be happening because Opera Mini (unreleased since 2015) is hovering at 1.029% usage. It's likely fluctuating above and below the currently defined 1% threshold from month to month. It's also required in Opera 11.5-12.1, but all of these are at 0% usage.

I think that we could probably consider dropping Opera from our explicitly defined browserslist in the near future. The entire Opera user base consistently sits at ~2%, and there's always the > 1% rule in the browserslist. More research will need to be done, though, to determine how that ~2% translates to WordPress users.

@mukesh27 commented on PR #5939:


4 weeks ago
#3

@desrosj Do we need package-lock.json changes?

@desrosj commented on PR #5939:


4 weeks ago
#4

@mukeshpanchal27 In this case, yes. The package that needs to be updated is not a direct dependency, so it's only defined within the lock file.

@jonsurrell commented on PR #5939:


4 weeks ago
#5

Yes, we hit problems and cherry-picked the package-lock changes here to unblock this work: https://github.com/WordPress/wordpress-develop/pull/5922#issuecomment-1910673494

When this PR lands that removes a blocker 👍

@desrosj commented on PR #5939:


4 weeks ago
#6

I'm going to commit this since this blocks other work and is a reasonable change to make. But I do have some concerns around the frequent churn related to these updates has caused recently. I documented these changes on the Trac ticket.

#7 @desrosj
4 weeks ago

In 57363:

Build/Test Tools: Update the caniuse data.

This updates the caniuse-lite database and includes all resulting CSS and built file changes, which are all minor changes due to fluctuations in browser usage.

Props gziolo, jonsurrell.
See #59657.

#9 @desrosj
2 weeks ago

  • Resolution set to fixed
  • Status changed from new to closed

Going to close this out. If another update is needed before final release, this ticket can be reopened.

Note: See TracTickets for help on using tickets.