Twenty Fifteen: Pullquote block issues with text color and border

[viralsampat]

Hello Team,

I have worked on the "Pullquote" block into the "Twenty Fifteen" theme and found that the text color for admin is not changed.

Here, I have attached its video.

Issue: ​https://share.cleanshot.com/2QPVLc7H737ghxjw8lft

Thanks,

[viralsampat]

I have checked above mentioned issue and resolved it. Here, I have added my patch.

[karmatosed]

Unless mistaken this patch will also remove the default color. Can you explore if this is the case @viralsampat and how to ensure it doesn't get removed?

[sabernhardt]

assigns lighter gray to .wp-block-pullquote, inherits special Text color for quotes, adjusts citation text color when block has a special Background color

[sabernhardt]

inherits text color for both blockquote and the citation, removes Pullquote-related changes from r58368

[sabernhardt]

Border

Both patch options edit the border styles the same ways.

1. The blockquote element should not have its own border. The editor shows one because the .editor-block-list__block class is obsolete and the selector needs to be replaced. (The extra border was also mentioned on #59612, but its latest patch only includes border color classes for the theme.)
2. I added a default border style of solid for the block so people would not need to use that control for the most common style.

Text Color

The default text color for this theme originally had a lighter gray for quotes, including the Pullquote block, and then it set the citation to the body color again.

blockquote {
  color: #707070;
  color: rgba(51, 51, 51, 0.7);
}
.wp-block-pullquote cite,
blockquote cite,
blockquote small {
  color: #333; /* body color */
}

However, WordPress 5.9 (GB30951) made the Pullquote's elements inherit the block color on the front end (except when a theme uses a higher specificity or sets the color later in the cascade) more than two years ago.

.wp-block-pullquote p,
.wp-block-pullquote blockquote,
.wp-block-pullquote cite {
  color: inherit;
}

Since 6.4, the iframe editor has also inherited the body color, so some people might not know that the colors were ever different. This could be considered an established design change, though unintentional.

59801.re-establish-color.patch​: I am not entirely comfortable with reassigning the color to the block container to re-establish the original design, but I made a patch to show how it might work.

• Sets semi-transparent gray (with fallback) on .wp-block-pullquote (and blockquote within the editor)
• Makes blockquote inherit any custom Text color
• Makes citation inherit the text color when a user chooses a different Background color (setting either a Text or Background color on the Pullquote does not necessarily mean that the user wanted the citation color to match the quote, but a dark Background requires the ability to change the citation color)

59801.inherit-all.patch​ would officially establish the matching colors with this theme.

• Makes both the blockquote and the citation inherit the text color from their containers
• Removes Pullquote-related changes from [58368]

[karmatosed]

@sabernhardt just checking on this before move it to testing and a candidate for commit. The following would be my ideal based on the options.

establish the matching colors with this theme.

I am aware it removes the changes from #58368 but that feels ok to me.

[sabernhardt]

59801.inherit-all.patch​ is probably the better choice for the direction now.

[karmatosed]

@sabernhardt thank you, I will test and look to progress that then.

[karmatosed]

I have tested this and can confirm it works as expected so moving to commit. Thank you everyone.

[karmatosed]

In 58724:

Twenty Fifteen: Fixes pullquote issues with text color and border

Pullquote was not showing the color changes. This uses inherit to do that. It also removes the changes from [58368] as this method is preferred.

Props viralsampat, poena, sabernhardt.
Fixes #59801.