Make WordPress Core

Opened 7 months ago

Closed 5 months ago

#59943 closed defect (bug) (fixed)

Text isnt highlighted when editing a page in latest Chrome Dev and Canary

Reported by: killerbeez's profile killerbeez Owned by: jorbin's profile jorbin
Milestone: 6.4.3 Priority: high
Severity: major Version: 6.1
Component: Editor Keywords: needs-patch
Focuses: ui, administration Cc:

Description

Not sure if this a WordPress bug or Chrome updates, however, when you edit a page and try to select and highlight over paragraph text, there is no background colour indicating where you are.
It only seems to happen in WordPress, and on front end and other sites, you can select the text and a background colour is visible

Change History (16)

#1 follow-up: @daviwalle
7 months ago

Hi there,

Can you try disabling all browser extensions? They could generate some incompatibility

Also, from what I've heard, the latest versions of Chrome Canary have some bugs with the Dark Modes implementations, do you use any dark mode function?

#2 in reply to: ↑ 1 ; follow-up: @killerbeez
7 months ago

Replying to daviwalle:

Hi there,

Can you try disabling all browser extensions? They could generate some incompatibility

Also, from what I've heard, the latest versions of Chrome Canary have some bugs with the Dark Modes implementations, do you use any dark mode function?

Hi Daviwalle, have also submitted to Chrome, more likely a new issue at their end.

Both browsers were clean on both macOS Sonoma and Windows, both same issues, tried both Normal and Dark mode.

Base WordPress install with 24 theme only.

#3 in reply to: ↑ 2 ; follow-up: @daviwalle
7 months ago

Replying to killerbeez:

Yes, it is probably Chrome. Does it happen in the whole WordPress BackEnd or only when editing?

#4 in reply to: ↑ 3 @killerbeez
7 months ago

Replying to daviwalle:

Replying to killerbeez:

Yes, it is probably Chrome. Does it happen in the whole WordPress BackEnd or only when editing?

Only in main editor section, if you try to adjust the title block at the very top it highlights and also the sidebar content it highlights fine.

#5 follow-up: @jorbin
7 months ago

  • Milestone changed from Awaiting Review to 6.4.2

Thank you for the ticket @killerbeez. You mentioned that you also submitted this to Chrome, can you link to the bug report there?

I can replicate this using Chrome Version 121.0.6154.0 (Official Build) canary (arm64) and WP 6.5-alpha-57081.

Milestoning in order to keep an eye on this and investigate if a change is going to be necessary.

#6 in reply to: ↑ 5 @killerbeez
7 months ago

Replying to jorbin:

Thank you for the ticket @killerbeez. You mentioned that you also submitted this to Chrome, can you link to the bug report there?

I can replicate this using Chrome Version 121.0.6154.0 (Official Build) canary (arm64) and WP 6.5-alpha-57081.

Milestoning in order to keep an eye on this and investigate if a change is going to be necessary.

Hi @jorbin,
This is trac https://bugs.chromium.org/p/chromium/issues/detail?id=1504444#c_ts1700696677
also the WP Git repo https://github.com/WordPress/gutenberg/issues/56408

#7 @SergeyBiryukov
7 months ago

  • Milestone changed from 6.4.2 to 6.4.3

#8 @swissspidy
6 months ago

#60088 was marked as a duplicate.

#9 @jorbin
6 months ago

  • Priority changed from normal to high

Based on this comment from a member of the chrome team, I think this is something we are going to want to look into fixing for 6.4.3

Anyways, it may be we delay this change for a few more releases. But long term there are 2 choices: push it out as is, or re-raise the CSS spec issue in the hope of coming up with a better resolution.

#10 @johnbillion
6 months ago

  • Focuses administration added
  • Keywords needs-patch added

This ticket was mentioned in Slack in #core by jorbin. View the logs.


6 months ago

This ticket was mentioned in Slack in #core-editor by jorbin. View the logs.


6 months ago

#13 @thesimarchitect
6 months ago

  • Focuses ui added
  • Severity changed from major to normal
  • Version changed from 6.4 to 6.4.2

Same problem. I know it's not a wordpress issue, but related, at the same time I also notice the bug when trying to edit a Tweet (I have access to formattation). Perhaps all formattable text boxes have this bug on Chrome? I am using Chrome Version 121.0.6167.16 (Official Build) beta (64-bit) and I am having this problem for the past couple of weeks, if I am not mistaken.

I didn't mean to change the topic priority or anything. I filled with my information, sorry if that was a mistake. 😬

Quick note: if you're editing the code instead of using visual mode it works normally. So, it seems to be a Chrome problem that affects text boxes with formatting. Editing other elements of a post like the excerpt, for example, doesn't present the issue either and the text is highlighted correctly.

Last edited 6 months ago by thesimarchitect (previous) (diff)

#14 @talldanwp
6 months ago

  • Severity changed from normal to major
  • Version changed from 6.4.2 to 6.1

@thesimarchitect No worries, I've changed those back.

I've started on a fix in this PR - https://github.com/WordPress/gutenberg/pull/57298.

I'm concerned about the impact this will have on WordPress users, even if a fix is released in 6.4.3. Do we know how many users will auto-update?

This is the PR that introduced the code that causes the issue, which was included in WordPress 6.1 - https://github.com/WordPress/gutenberg/pull/44148.

#15 @talldanwp
6 months ago

The problem was fixed in this gutenberg PR - https://github.com/WordPress/gutenberg/pull/57300.

The Chrome team indicated they'll delay the feature that resulted in this issue, but I don't know how long for - https://github.com/WordPress/gutenberg/issues/56408#issuecomment-1866399889.

#16 @jorbin
5 months ago

  • Owner set to jorbin
  • Resolution set to fixed
  • Status changed from new to closed

In 57258:

Editor: update npm packages in trunk for 6.4.3.

Package Update includes fixes for:

  • Image Block: Enable image block to be selected correctly when clicked.
  • Reduce specificity of default Cover text color styles.
  • Image Block: Fix deprecation when width/height attribute is number.
  • Text selection: show CSS hack to Safari only.
  • SlotFill: Allow contextual SlotFillProviders.

See: https://github.com/WordPress/wordpress-develop/pull/5696
See: https://github.com/WordPress/gutenberg/commit/bd6767b8a4f9461153a6db6374110f723ed0d05c
See: https://github.com/WordPress/gutenberg/pull/56043
See: https://github.com/WordPress/gutenberg/pull/56411
See: https://github.com/WordPress/gutenberg/pull/57063
See: https://github.com/WordPress/gutenberg/pull/57300
See: https://github.com/WordPress/gutenberg/pull/56779

Props mikachan, wildworks, alexstine, poena, isabel_brison, andrewserong, czapla, andraganescu, joen, ellatrix, youknowriad, ntsekouras.
Fixes #59943, #59943.

Note: See TracTickets for help on using tickets.