Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#60415 closed defect (bug) (fixed)

Coding Standards: Need to improve below two files comparison operator conditions.

Reported by: upadalavipul's profile upadalavipul Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.5 Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: coding-standards Cc:

Description

I have reviewed the code and found the two files in condition check only != operator. but as per the coding standard needs to be checked !== operator. Please check below to provide two file codes.

Files:

  1. wp-admin/plugin-editor.php
  2. wp-admin/theme-editor.php

Attachments (11)

60415.patch (2.4 KB) - added by upadalavipul 2 years ago.
added patch
60415.3.patch (1.6 KB) - added by viralsampat 2 years ago.
60415.2.patch (3.1 KB) - added by viralsampat 2 years ago.
I have checked above mentioned issue and founds few more files. I have applied its patch.
60415.4.patch (1.2 KB) - added by upadalavipul 2 years ago.
Added new patch
60415.5.patch (4.6 KB) - added by upadalavipul 2 years ago.
Added one more patch
60415.6.patch (3.0 KB) - added by upadalavipul 2 years ago.
added new patch
60415.7.patch (944 bytes) - added by upadalavipul 2 years ago.
Added new patch
60415.8.patch (944 bytes) - added by upadalavipul 2 years ago.
Added new patch
60415.9.patch (2.8 KB) - added by viralsampat 2 years ago.
I have added another patch
60415.10.patch (13.0 KB) - added by viralsampat 2 years ago.
I have checked above mentioned issue and founds few files. Here, I have added its patch.
60415.11.patch (11.4 KB) - added by viralsampat 2 years ago.
I have checked above mentioned issue and founds few files. Here, I have added its patch.

Download all attachments as: .zip

Change History (15)

@upadalavipul
2 years ago

added patch

@viralsampat
2 years ago

#1 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 6.5

#2 @SergeyBiryukov
2 years ago

In 57522:

Coding Standards: Use strict comparison for functions lookup in plugin/theme editors.

Follow-up to [10607], [44617].

Props upadalavipul.
See #60415.

#3 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 57529:

Coding Standards: Use strict comparison in wp-admin/update-core.php.

Follow-up to [11273], [25784], [54654].

Props wpfy, mukesh27, azaozz, viralsampat.
Fixes #58061, #60415.

@viralsampat
2 years ago

I have checked above mentioned issue and founds few more files. I have applied its patch.

@upadalavipul
2 years ago

Added new patch

@upadalavipul
2 years ago

Added one more patch

@upadalavipul
2 years ago

added new patch

#4 @SergeyBiryukov
2 years ago

Thanks for the patches! It looks like these are all external libraries though, they don't have to follow the WordPress coding standards, and should not be changed directly in core.

@upadalavipul
2 years ago

Added new patch

@upadalavipul
2 years ago

Added new patch

@viralsampat
2 years ago

I have added another patch

@viralsampat
2 years ago

I have checked above mentioned issue and founds few files. Here, I have added its patch.

@viralsampat
2 years ago

I have checked above mentioned issue and founds few files. Here, I have added its patch.

Note: See TracTickets for help on using tickets.