Context Navigation

← Previous Ticket
Next Ticket →

#63637 closed defect (bug) (fixed)

Twenty Seventeen: PHPDoc block are missing for the_content filter hooks

Reported by:	pmbaldha	Owned by:	peterwilsoncc
Priority:	normal	Milestone:	6.9
Component:	Bundled Theme	Version:
Severity:	normal	Keywords:	has-patch commit
Cc:		Focuses:	docs, coding-standards

Description

PHPDoc blocks are missing in the following places:

https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentyseventeen/template-parts/post/content-video.php#L45

https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentyseventeen/template-parts/post/content-audio.php#L45

Please add PHPDoc blocks for them.

Change History (7)

#1 @mukesh27
13 months ago

Component Themes → Bundled Theme
Focuses docs added
Keywords needs-patch added
Summary PHPDoc block are missing for the_content filter hooks in the Twenty Seventeen theme → Twenty Seventeen: PHPDoc block are missing for the_content filter hooks

This ticket was mentioned in PR #9132 on WordPress/wordpress-develop by @pmbaldha.

13 months ago #2

Keywords has-patch added; needs-patch removed

Trac ticket: https://core.trac.wordpress.org/ticket/63637

@mukesh27 commented on PR #9132:

13 months ago #3

Nice!

TT1 have similar comment https://github.com/WordPress/wordpress-develop/blob/c08537d178014271e8e1ac1d0becb3a2b7ac9d3a/src/wp-content/themes/twentytwentyone/inc/template-functions.php#L400

#4 @mukesh27
13 months ago

Keywords commit added
Milestone Awaiting Review → 6.9
Type enhancement → defect (bug)

@peterwilsoncc commented on PR #9132:

13 months ago #5

While reviewing the hooks in 2017, I noticed that a docblock was missing for the twentyseventeen_should_show_featured_image filter.

https://github.com/WordPress/wordpress-develop/blob/a8b9dc1df086370f1a64f4951a0815be1e712e62/src/wp-content/themes/twentyseventeen/functions.php#L709-L712

While fixing the docblock for the other hook, it would be great to fix this one too. Are you able to assist? The hook was introduced in version 3.7 of the theme.

@sabernhardt commented on PR #9132:

13 months ago #6

@peterwilsoncc The twentyseventeen_should_show_featured_image filter's docblock (currently) has its own ticket (63644) and PR #9167.

#7 @peterwilsoncc
12 months ago

Owner set to peterwilsoncc
Resolution → fixed
Status new → closed

In 60430:

Twenty Seventeen: Document the the_content filter.

Adds documentation references to the filter's docblock in wp-includes/post-template.php.

Follow-up to [38833].

Props pmbaldha, mukesh27, sabernhardt.
Fixes #63637.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#63637 closed defect (bug) (fixed)

Twenty Seventeen: PHPDoc block are missing for the_content filter hooks

Description

Change History (7)

#1 @mukesh27 13 months ago

This ticket was mentioned in ​PR #9132 on ​WordPress/wordpress-develop by ​@pmbaldha. 13 months ago #2

​@mukesh27 commented on ​PR #9132: 13 months ago #3

#4 @mukesh27 13 months ago

​@peterwilsoncc commented on ​PR #9132: 13 months ago #5

​@sabernhardt commented on ​PR #9132: 13 months ago #6

#7 @peterwilsoncc 12 months ago