Broken styling on "Add Plugins" screen

[TobiasBg]

A fresh install of WP 6.9 has broken styling on the "Add Plugins" screen (/wp-admin/plugin-install.php).

There is no spacing between the tabs bar (Featured/Popular/Recommended/Favorites) and the plugin cards anymore.

See attached screenshot.

Set the plugins tab bottom margin to 1rem, matching the old description margin.

Trac ticket: https://core.trac.wordpress.org/ticket/64337

[sajib1223]

After adding a 1rem bottom margin to the .wp-filter element

[sabernhardt]

If the bottom margin is added to .wp-filter, the .table-nav.top page navigation probably should not have the 5 pixels of top padding when visiting the 'Popular' tab (and possibly other tabs).

[60528] added a line break to fix the lack of space on the Features tab, which worked in development when 'Beta testing' was the first tab. Now 'Features' is usually the first tab, and the featured plugins display—without the space—when the URL does not include a tab parameter.

For another option, I think the <br /> could work earlier, instead of using $_GET['tab']:

case 'install_plugins_featured':
	echo '<br />';
	break;

Trac ticket: https://core.trac.wordpress.org/ticket/64337

After PR:

I agree with @sabernhardt’s comment here https://core.trac.wordpress.org/ticket/64337#comment:2, and it would be better to add a generic solution instead of adding additional CSS.

[narenin]

Test Report

I have tested latest patch and it is working as expected. ​https://github.com/WordPress/wordpress-develop/pull/10587

Environment

WordPress: 6.9
PHP: 8.1.23
Server: nginx/1.16.0
Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.23)
Browser: Chrome 126.0.0.0 (macOS)
Theme: Twenty TwentyVersion: 2.7

Expected Results

The spacing issue between the tabs bar (Featured/Popular/Recommended/Favorites) and the plugin cards has been fixed.

Screenshot:

[westonruter]

In 61353:

Plugins: Restore line break between the filter links row and the plugin cards in the Featured view.

Follow-up to [60528].

Props mukesh27, sajib1223, TobiasBg, narenin, sabernhardt, westonruter.
See #63723.
Fixes #64337.

[westonruter]

Re-opening for 6.9.1 backport consideration.

[wildworks]

Re-opening for 6.9.1 backport consideration.

Approved ✅

[peterwilsoncc]

In 61382:

Plugins: Restore line break between the filter links row and the plugin cards in the Featured view.

Follow-up to [60528].

Reviewed by wildworks.
Merges [61353] to the 6.9 branch.

Props mukesh27, sajib1223, TobiasBg, narenin, sabernhardt, westonruter.
See #63723.
Fixes #64337.