WordPress.org

Make WordPress Core

Opened 11 years ago

Last modified 4 months ago

#8368 assigned enhancement

Scheduling post time behavior and language refinements

Reported by: jane Owned by: garyc40
Milestone: Future Release Priority: normal
Severity: normal Version: 2.7
Component: Editor Keywords: needs-patch
Focuses: ui Cc:

Description

On post editor, in publish module, at Publish Immediately-Edit.

If click Edit, layer opens revealing the entry boxes for date and time of publication but still says Publish Immediately. Text should change to say "Publish at:" b/c it's weird if you change time and screen still says immediately until you click OK.

Move OK button to the right side of module (submission buttons to the right as standard placement) with cancel to left (as with other places).

If you start to type in an alternate time then hit cancel, it reverts to publish immediately, which makes sense. If you have already scheduled the publish time but you decide to change it and start typing a different alternate time, if you hit cancel it does not revert to your originally scheduled time, but to publish immediately. It should revert to your previously saved schedule time. Should have a separate link to revert to publish immediately.

Attachments (2)

garyc40.8368.diff (7.1 KB) - added by garyc40 9 years ago.
8368.patch (6.8 KB) - added by SergeyBiryukov 8 years ago.

Download all attachments as: .zip

Change History (31)

#1 @ryan
11 years ago

  • Component changed from General to UI
  • Owner anonymous deleted

#2 @markjaquith
11 years ago

  • Milestone changed from 2.7 to 2.8
  • Owner set to markjaquith
  • Status changed from new to assigned

Will refine in 2.8

#3 @Denis-de-Bernardy
10 years ago

  • Keywords needs-patch added

#4 @janeforshort
10 years ago

  • Milestone changed from 2.8 to 2.9

Pushing to next release due to schedule.

#5 @Denis-de-Bernardy
10 years ago

  • Milestone changed from 2.9 to Future Release

#6 follow-up: @JohnONolan
9 years ago

  • Keywords ux-feedback 3.2-early added

Related: #16068

Proposed solution, approved by Jane: http://cl.ly/452E

#7 @garyc40
9 years ago

  • Owner changed from markjaquith to garyc40
  • Status changed from accepted to assigned

@garyc40
9 years ago

#8 in reply to: ↑ 6 @garyc40
9 years ago

  • Keywords has-patch added; needs-patch removed

Replying to JohnONolan:

Related: #16068

Proposed solution, approved by Jane: http://cl.ly/452E

The patch I attached goes with this direction. The radio boxes are displayed only when we're editing a scheduled post. Otherwise, the default UI is used.

If click Edit, layer opens revealing the entry boxes for date and time of publication but still says Publish Immediately. Text should change to say "Publish at:" b/c it's weird if you change time and screen still says immediately until you click OK.

This issue is addressed in the attached patch as well

Also, when you change the date to something other than the original scheduled date, but ahead of current time, the text should change to say "Schedule for" instead of "Published on", and the submit button should change to "Schedule" instead of "Update". My patch addresses this issue as well.

#9 @solarissmoke
8 years ago

Closed #17143 as duplicate

#11 @sjefen6
8 years ago

Bump, +1

@SergeyBiryukov
8 years ago

#12 @SergeyBiryukov
8 years ago

Refreshed the patch for current trunk, in case someone wants to look at it.

#14 follow-up: @SergeyBiryukov
8 years ago

  • Keywords needs-patch added; has-patch removed

Related/duplicate: #18565

So this bug is now about the fact that you can Quick Edit a post and change it from Scheduled to Published, but nothing occurs.

Need to address that in the patch.

#15 @nacin
8 years ago

  • Reporter changed from janeforshort to jane

#16 @Probeus
8 years ago

Created a hotfix with userscript. Adds a button who updates the date to the current date when its clicked.

http://userscripts.org/scripts/show/119952

#17 @SergeyBiryukov
7 years ago

#23153 was marked as a duplicate.

#18 @bi0xid
7 years ago

  • Cc raven@… added

#19 @sabreuse
7 years ago

  • Component changed from UI to Editor
  • Keywords ui-focus added; ux-feedback removed

#20 follow-up: @danielbachhuber
6 years ago

  • Cc raven@… daniel@… added; raven@… removed
  • Keywords 3.2-early removed

A client of ours refuses to use the scheduled posts feature because "when we scheduled a post, there was no way to revert to a 'publish immediately' status."

The radio button UI proposed by JohnONolan seems like a reasonable solution. Happy to hack it into a plugin that can be user-tested if that's the best way to get the enhancement into core.

#21 in reply to: ↑ 20 @nacin
6 years ago

Replying to danielbachhuber:

Happy to hack it into a plugin that can be user-tested if that's the best way to get the enhancement into core.

I think a patch would be sufficient for user testing. If you can whip one up, I can help find someone to design and run some tests (unless you want to). I wouldn't want you to go through the trouble of making a plugin for something this small, especially since it'll just be a big JS hack that won't port well into a patch.

Given a patch that works OK, we can ship this in 3.9 for sure. This has been a thorn for far too long.

#22 follow-up: @DragonFlyEye
5 years ago

Shouldn't the version designation for this be updated to 3.9, if you're planning on fixing it for this release (pretty, pretty please!)?

#23 in reply to: ↑ 22 @miqrogroove
5 years ago

Replying to DragonFlyEye:

Shouldn't the version designation for this be updated to 3.9, if you're planning on fixing it for this release (pretty, pretty please!)?

He said, "Given a patch", and there is no patch. Future Release is still correct.

#24 @Denis-de-Bernardy
5 years ago

https://core.trac.wordpress.org/ticket/8368#comment:6

Any volunteers to create the patch for the above?

#25 @danielbachhuber
5 years ago

I can work on a patch for 4.0-early.

#26 in reply to: ↑ 14 @Denis-de-Bernardy
5 years ago

Replying to SergeyBiryukov:

Related/duplicate: #18565

So this bug is now about the fact that you can Quick Edit a post and change it from Scheduled to Published, but nothing occurs.

Need to address that in the patch.

Not sure it should, but yeah… it could. That can of works would be related to #27578, #19907, #22350 and #16985. Which is simple to fix from within wp_insert_post():

        if (in_array($post_data['post_status'], array('draft', 'pending', 'auto-draft'))) {
            $post_data['post_date_gmt'] = '0000-00-00 00:00:00';
        }

(There's also subsequently dead code within wp_update_post() to remove if the above gets checked in.)

Last edited 5 years ago by Denis-de-Bernardy (previous) (diff)

#27 @chriscct7
4 years ago

  • Priority changed from low to normal
  • Severity changed from minor to normal

#28 @khag7
3 years ago

I plan to work on this. I will implement the patch by @SergeyBiryukov which should create an interface like this and also handle quickedit as follows:

  • add "now" button next to date
  • in status dropdown, published should never show if date is in future
  • in status dropdown, scheduled should never show if date is in past/present
  • date input onblur, re-check date future/present/past and add/remove published/scheduled options

This ticket was mentioned in Slack in #core-restapi by danielbachhuber. View the logs.


12 months ago

Note: See TracTickets for help on using tickets.