Make WordPress Core

Opened 15 years ago

Closed 15 years ago

#9838 closed defect (bug) (fixed)

Don't show "Selected plugins deactivated." notification if all of selected plugins are deactivated before action.

Reported by: simek's profile Simek Owned by: dd32's profile dd32
Milestone: 2.8 Priority: normal
Severity: minor Version: 2.8
Component: UI Keywords: needs-patch
Focuses: Cc:

Description (last modified by dd32)

Status completion messages should not be shown if no actions are performed. (Eg, Don't show "Selected plugins deactivated." notification if all of selected plugins are deactivated before action.)

A similar situation happens with plugin activation, as well as Plugin deletion.

There exists an issue where Active plugins can be deleted via the Bulk actions as well.

(Edited by dd32 to merge #9837 and mention similar bugs)

Attachments (5)

9838.diff (6.4 KB) - added by dd32 15 years ago.
9838.2.diff (6.3 KB) - added by dd32 15 years ago.
9838.3.diff (7.7 KB) - added by dd32 15 years ago.
9838.4.diff (5.6 KB) - added by dd32 15 years ago.
9838.5.diff (6.3 KB) - added by dd32 15 years ago.

Download all attachments as: .zip

Change History (21)

#1 @Simek
15 years ago

  • Type changed from defect (bug) to feature request

#2 @Denis-de-Bernardy
15 years ago

  • Component changed from Plugins to UI
  • Type changed from feature request to defect (bug)

#3 @dd32
15 years ago

  • Owner set to dd32
  • Status changed from new to accepted

I'll take a look at this tomorrow

#4 @Simek
15 years ago

Same problem with activate action

#5 @dd32
15 years ago

  • Description modified (diff)

Patch pending #9835 closure due to code conflicts. (I could post a patch, But it'll only make one or the other stale, I'm going to get some feedback on the other ticket first before submitting this patch)

Note, I've also closed #9837 as a duplicate of this and merging the problems, Due to the actual issue being very similar

@dd32
15 years ago

#6 @Denis-de-Bernardy
15 years ago

  • Keywords has-patch added; needs-patch removed

#7 @dd32
15 years ago

attachment 9838.diff added

  • Doesnt attempt to activate/deactivate an already activated/deactivated plugin via bulk action
  • Bit of extra white space
  • correction of paragraph around the Version and Author name
  • Adds Bulk actions dropdown at the bottom of the table, like the other tables.

(Patch is about to be refreshed due to a new-line issue.)

@dd32
15 years ago

#8 @dd32
15 years ago

hang on, That's a dodgy patch.. refresh coming up again.

@dd32
15 years ago

#9 @dd32
15 years ago

attachment 9838.3.diff added

  • Same as before, Moves the Delete link to the 3rd position, moving the Visit plugin homepage back to the last item
  • Some more spacing issues here and there.
  • Also changed the $sep in the actions link code to use end() instead of a counter.. Its a bit more expensive timewise, but looks cleaner, and is only *just* a little slower..

@dd32
15 years ago

#10 @dd32
15 years ago

  • Priority changed from low to normal

attachment 9838.4.diff added

  • Final unrequested patch refresh.
  • Doesnt have the Actions changes from the previous patches since its now no longer needed.
  • Else, Everything else from the original patch is there. So..
    • Doesnt attempt to activate/deactivate an already activated/deactivated plugin via bulk action
    • Doesnt show completed messages when nothing was completed
    • Adds the Actions to the bottom of the table as well.

#11 @dd32
15 years ago

  • Keywords needs-patch added; has-patch removed

Just noticed something else i missed in this patch.. I'll make a new one up this evening.

Also closed #9941 as a duplicate of this, It'll be corrected thanks to the array filtering in this ticket.

@dd32
15 years ago

#12 @dd32
15 years ago

  • Keywords has-patch added; needs-patch removed

#13 @azaozz
15 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [11474]) Adds the bulk actions to the bottom of the plugins listing table and other fixes, props dd32, fixes #9838

#14 @Simek
15 years ago

  • Keywords needs-patch added; has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Maybe some fixes were made, but problem mentioned in ticket is still not fixed.

#15 follow-up: @dd32
15 years ago

Status completion messages should not be shown if no actions are performed. (Eg, Don't show "Selected plugins deactivated." notification if all of selected plugins are deactivated before action.)

Seems fixed. Select active plugins, Activate = No message. Select inactive plugins, deactivate - no message. Select Active+inactive plugin, deactivate = message that selected plugins are deactivated (ok, semi true, not all selected are..)

A similar situation happens with plugin activation, as well as Plugin deletion.

Done too.

There exists an issue where Active plugins can be deleted via the Bulk actions as well.

Active plugins upon being deleted, are not shown in the list of "plugins to delete".

What problems are not fixed, And if its the first one here, What'd you expect to happen?

#16 in reply to: ↑ 15 @Simek
15 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Everything is ok now. My mistake ;)

Note: See TracTickets for help on using tickets.