Object Access Violation in repair.php and is_blog_installed()

[hakre]

On line 36 in /wp-admin/maint/repair.php the global $wpdb of type wpdb is accessing the following private member: wpdb::$old_tables. That member has been defined with @access private. The code must reflect that.

There is an additional access violation in the same script by accessing the private tables member.

The errors were introduced in [11902] by ryan. wpdb should offer a public member to check for deprecated tables.

Related: #11799

[hakre]

testcases

[hakre]

Patch Info
Patch adds an additional public member to class wpdb that provides the needed data. additionally it saves some function calls in repair.php because the list of table names is already filtered prior to iterate it.

Test-Results

Old-Test
Result: OK
All-Test
Result: OK
Current-Test
Result: OK
Default-Test
Result: OK

[hakre]

The actual patch.

[hakre]

Another access violation in is_blog_installed() in /wp-includes/functions.php.

[hakre]

Found another one in is_blog_installed(). Precisely spoken, that function might not look for all but only for current tables and skip the deprecated ones here. Just as a sidenote.

[nacin]

#12083