Eliminate dynamic function definitions, ie create_function

[ScottMac]

create_function() calls are essentially a form of eval() where the body of the functions is defined at runtime rather than compile time. This patch removes all but one of the calls within the translation code.

There are a few reasons for doing this, one is apc can't cache the results of the function definition and secondly HipHop doesn't support complex create_function definitions.

Most of the references were array_filter / array_map and replaced with a simple foreach.

Others were sorting and a callback function was added.

[Denis-de-Bernardy]

Needs a bit more massaging. The first foreach loop, for instance, does not initialize the array.

[ScottMac]

Thanks, I've fixed that now.

[nacin]

kses ones are here: #14245.

[nacin]

[16034] missed the ticket.

I think we have that exact helper function in deprecated.php, _funky_javascript_callback().

[nacin]

Related, kind of: #14245

[westi]

(In [16035]) Purger more create_function usage during autop and iso descrambling. See #14424 props ScottMac.

[westi]

Replying to nacin:

[16034] missed the ticket.

I think we have that exact helper function in deprecated.php, _funky_javascript_callback().

Looks like it - duplicated code FTL

[nacin]

[16312]

[nacin]

(In [16313]) Remove more create_function calls. props huichen, see #14424.

[nacin]

huichen was the Google Summer of Code student for HipHip, and one of his tasks was to make WordPress run on it.

Last commit came from here: ​https://github.com/huichen/wordpress/commit/a1cf1b0b3c496f4f8ee0295200208fada877eae8

[automattor]

(In [16317]) Typo fix. see #14424.

[nacin]

HipHop ticket from Hui: #14642

[markjaquith]

Done with this for 3.1.

[hakre]

Replying to nacin:

(In [16313]) Remove more create_function calls. props huichen, see #14424.

And Replying to nacin:

huichen was the Google Summer of Code student for HipHop, and one of his tasks was to make WordPress run on it.

Related: #16059

[ocean90]

In r16313 _wp_tag_cloud_name_sort_cb and _wp_tag_cloud_count_sort_cb are introduced but not used. Patch will fix it.

[ryan]

In [18814]:

Use _wp_tag_cloud_count_sort_cb instead of an anonymous function. Props ocean90. see #14424

[ryan]

Punting any further work from 3.3.

[nacin]

In [18815]:

Make the sort-by-object-property functions generic. see #14424.

[rmccue]

PHP is ​considering deprecating create_function in 5.6 (~2015). This isn't accepted or anywhere close yet, but as a matter of best practice, we should avoid using it in core.

With the exception of the usage in POMO and wp_generate_tag_cloud, these seem pretty trivial to convert to normal functions. Alternatively, we can wait until it's accepted and nearing release, by which point I hazard a guess we can consider 5.3+ with closures anyway.

[nacin]

I am all for doing whatever it takes to removing all uses of create_function(), even outright refactoring.

[obenland]

Patch converts the remaining ones, outside of POMO and the AtomParser class.

I noticed that importers were sorted twice, once with strcmp() and once with strnatcasecmp(). Is it okay to go with the latter in both cases?

[markjaquith]

Replying to obenland:

I noticed that importers were sorted twice, once with strcmp() and once with strnatcasecmp(). Is it okay to go with the latter in both cases?

Should be fine.

[markjaquith]

refresh

[markjaquith]

rename one of the callbacks to be more generic

[markjaquith]

without modifying a superglobal

[markjaquith]

So, I don't know whether that $_GET['paged'] superglobal modification was just for the limit, or if other things depend on it. I really don't like it, and would like to remove it.

[markjaquith]

merge 14424.4.diff and 14424.5.diff

[markjaquith]

Add a test for get_importers() ordering

[markjaquith]

In 27373:

Eliminate some of our last remaining create_function() instances

• Moved some into private function callbacks
• Eliminated some that weren't necessary anymore

props obenland, markjaquith, nacin. fixes #14424

[nacin]

In 27374:

Slight renaming in our callback in [27373]. see #14424.

[nacin]

In 27376:

Accept nooped plurals in wp_generate_tag_cloud() / wp_tag_cloud().

Renders topic_count_text_callback more or less obsolete. It can still be used, but passing a plural is easier.

fixes #27262. see #7989, #14424.

[lpointet]

Replying to nacin:

In 27374:

Slight renaming in our callback in [27373]. see #14424.

It seems _uasort_by_first_member callback was directly used in wp-admin/import.php (line 77). This commit leads then to the following PHP warning:

uasort() expects parameter 2 to be a valid callback, function '_uasort_by_first_member' not found or invalid function name

The callback should be updated in that file too, or we may use a new function to merge data from get_importers() and wp_get_popular_importers()?

[SergeyBiryukov]

In 27465:

Use correct function name. see [27374].

props lpointet.
see #14424.

[nacin]

In 27501:

Assign correct variable.

props nendeb55.
fixes #27351. see #14424, [27373].

[TobiasBg]

Replace a forgotten $GET['paged']

[TobiasBg]

[27373] forget one instance of $_GET['paged'] (this causes a notice e.g. in the old media uploader), see 14424-fix.diff​.

[nacin]

In 27675:

Use correct variable. see [27373].

props TobiasBg.
fixes #14424.