WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#32016 closed defect (bug) (duplicate)

List table views: Comments "Approved" link missing count

Reported by: afercia Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Comments Keywords: has-patch
Focuses: ui Cc:

Description

Not sure, maybe I'm missing something but couldn't find any reason why the comments count is not displayed for the "Approved" comments.

Now that in the Dashboard the count in the "At a glance" section shows the number of approved comments instead of all comments, see #26738, it would be nice to find the same number displayed in the Comments screen.

In the proposed patch:
add missing count for "Approved" comments in the list table views links

Screenshot before and after:

https://cldup.com/S87dVnoilB.png

Attachments (1)

32016.patch (1.2 KB) - added by afercia 7 years ago.

Download all attachments as: .zip

Change History (4)

@afercia
7 years ago

#1 @afercia
7 years ago

  • Keywords has-patch added

#2 follow-up: @ocean90
7 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed
  • Version 4.1 deleted

Would you like to refresh the patch on #11200? :)

See also #17275.

#3 in reply to: ↑ 2 @afercia
7 years ago

Replying to ocean90:

Would you like to refresh the patch on #11200? :)

See also #17275.

Ah, you see when you're old like me :) you just miss things. 5 years and no progress on this, interesting. I've started to have a look at the JS part, as far as I see there's at least one edge case where the logic is broken. Some things need to make a decision and should be discussed. Also, there are far better JavaScript programmers than me and they could fix this in 1/10 of the time I would need to :)

Note: See TracTickets for help on using tickets.