WordPress.org

Make WordPress Core

Opened 6 years ago

Last modified 10 months ago

#32626 new enhancement

List tables CSS: inconsistent alignments

Reported by: afercia Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 4.2
Component: Administration Keywords:
Focuses: ui, css Cc:

Description

While working on #31654 noticed inconsistencies in the alignments of the checkboxes and also some other small details in the List Tables that would need a bit of love, see the screenshot below for some examples. This would also greatly simplify the List Tables CSS where many (crazy) selectors are just to override exceptions that override other exceptions etc. See also related #29990.

https://cldup.com/T48AqNGdT0.png

A possible plan would be:

  • stick to a default padding for the cells with checkboxes (10px ?)
  • the checkbox in the table headers would probably need no padding and vertical-align: middle to handle #29990
  • handle the special case for comments, plugins and network themes in a consistent way
  • there's a 1 pixel difference in the vertical alignment of links and normal text in the table headers
  • images should be consistently aligned

Change History (6)

#1 @swissspidy
6 years ago

  • Keywords reporter-feedback added

With the recent improvements to list tables, is this still an issue?

#2 @afercia
6 years ago

Maybe a couple of things were improved in recent developments, still there's some CSS chaos to do a thing that should be simpler. I'd agree this should probably be handled as part of a major CSS audit, see the CSS roadmap. Maybe it should have been marked as enhancement since the beginning. Would you agree to mark it as enhancement for a future release?

#3 @swissspidy
6 years ago

  • Keywords reporter-feedback removed
  • Milestone changed from Awaiting Review to Future Release
  • Type changed from defect (bug) to enhancement

Works for me :)

#4 @helen
6 years ago

list-tables.css L385: /* @todo: pick a consistent list table selector */

Chaos is still too nice of a word for it. We'll get here, someday. In the meantime, figuring out what all the visual test cases we would need for list tables would be good, as visual regression testing is a critical component of the clean up plan.

#5 @garrett-eclipse
17 months ago

  • Focuses css added

#6 @netweb
10 months ago

  • Milestone set to Future Release

Not sure how the milestone was removed here, adding it back to future-release

Note: See TracTickets for help on using tickets.