WordPress.org

Make WordPress Core

Opened 22 months ago

Last modified 19 months ago

#37411 accepted defect (bug)

Add more formats to wp_maybe_decline_date()

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: Future Release Priority: normal
Severity: normal Version: 4.4
Component: Date/Time Keywords: has-patch needs-testing needs-unit-tests
Focuses: Cc:

Description (last modified by SergeyBiryukov)

In some themes, date format is not localized (see an example in Sadakalo theme).

Formats like 'F jS Y' don't make a lot of sense for languages with declensions, which generally use 'j F Y' (where F requires genitive case).

We could improve the situation by adding more formats to wp_maybe_decline_date() introduced in #11226.

Attachments (1)

37411.patch (1.4 KB) - added by SergeyBiryukov 22 months ago.

Download all attachments as: .zip

Change History (14)

#1 @SergeyBiryukov
22 months ago

  • Keywords 4.7-early added

#2 @SergeyBiryukov
22 months ago

  • Keywords needs-patch added; has-patch removed

j F, Y should be handled as well.

#3 @SergeyBiryukov
22 months ago

  • Description modified (diff)

This ticket was mentioned in Slack in #core by helen. View the logs.


21 months ago

#5 @SergeyBiryukov
21 months ago

  • Keywords 4.7-early removed
  • Milestone changed from Awaiting Review to 4.7
  • Owner set to SergeyBiryukov
  • Status changed from new to accepted

This ticket was mentioned in Slack in #core by desrosj. View the logs.


20 months ago

#7 @desrosj
20 months ago

  • Keywords has-patch added; needs-patch removed

#8 @desrosj
20 months ago

  • Keywords needs-testing added; needs-unit-tests removed

@SergeyBiryukov This looks like it just needs testing?

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


20 months ago

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


20 months ago

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


19 months ago

#13 @helen
19 months ago

  • Milestone changed from 4.7 to Future Release

No activity, punting. If it's a bug we need to fix for 4.7 (it feels more like an enhancement in some ways), you know how to bring it back.

Note: See TracTickets for help on using tickets.